[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #497: [FLINK-30528] Reconcile other changes if upgrade is not available

[GitBox <gi...@apache.org>]

morhidi commented on code in PR #497:
URL: https://github.com/apache/flink-kubernetes-operator/pull/497#discussion_r1059675574


##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconcilerTest.java:
##########
@@ -706,4 +707,47 @@ public void testRestartUnhealthyEvent() throws Exception {
         reconciler.reconcile(deployment, context);
         Assertions.assertEquals(MSG_RESTART_UNHEALTHY, eventCollector.events.remove().getMessage());
     }
+
+    @Test
+    public void testReconcileIfUpgradeModeNotAvailable() throws Exception {

Review Comment:
   Could you please add comments to the test @gyfora? It's really hard to follow what it actually does.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org