You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@archiva.apache.org by Martin Stockhammer <ma...@apache.org> on 2017/08/28 15:59:33 UTC

RepositorySessionFactory injected

Hi,

I stumbled about some fixme comments on RepositorySessionFactory injection fields:
FIXME: this could be multiple implementations and needs to be configured.

Are these still relevant? As I understand there is a RepositorySessionFactoryBean that selects the factory based on configuration.  And the injected fields get the right implementation without changes on the their side.
If this is the case, I will remove these comments.

Cheers

Martin


-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Re: RepositorySessionFactory injected

Posted by Olivier Lamy <ol...@apache.org>.
I wish :-)


On 31 August 2017 at 05:07, Martin Stockhammer <ma...@apache.org> wrote:

> Ok, found a ticket about it. The existing RepositorySessionFactoryBean can
> only switch the factory during startup. You want it to be configurable
> without restart?
>
> Greetings
>
> Martin
>
>
>
>
>
>
> Am 30. August 2017 09:06:14 MESZ schrieb Olivier Lamy <ol...@apache.org>:
>>
>> Hi
>> Well I was expecting users to be able to configure this via ui (i.e
>> dynamically) not only via spring so the comment.
>> But never got time to finish that :-)
>>
>>
>> On 29 August 2017 at 01:59, Martin Stockhammer <ma...@apache.org> wrote:
>>
>>  Hi,
>>>
>>>  I stumbled about some fixme comments on RepositorySessionFactory injection
>>>  fields:
>>>  FIXME: this could be multiple implementations and needs to be configured.
>>>
>>>  Are these still relevant? As I understand there is a
>>>  RepositorySessionFactoryBean that selects the factory based on
>>>  configuration.  And the injected fields get the right implementation
>>>  without changes on the their side.
>>>  If this is the case, I will remove these comments.
>>>
>>>  Cheers
>>>
>>>  Martin
>>>
>>>
>>>  --
>>>  Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
>>>
>>
>>
>>
>>
> --
> Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
>



-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: RepositorySessionFactory injected

Posted by Martin Stockhammer <ma...@apache.org>.
Ok, found a ticket about it. The existing RepositorySessionFactoryBean can only switch the factory during startup. You want it to be configurable without restart?

Greetings

Martin






Am 30. August 2017 09:06:14 MESZ schrieb Olivier Lamy <ol...@apache.org>:
>Hi
>Well I was expecting users to be able to configure this via ui (i.e
>dynamically) not only via spring so the comment.
>But never got time to finish that :-)
>
>
>On 29 August 2017 at 01:59, Martin Stockhammer <ma...@apache.org>
>wrote:
>
>> Hi,
>>
>> I stumbled about some fixme comments on RepositorySessionFactory
>injection
>> fields:
>> FIXME: this could be multiple implementations and needs to be
>configured.
>>
>> Are these still relevant? As I understand there is a
>> RepositorySessionFactoryBean that selects the factory based on
>> configuration.  And the injected fields get the right implementation
>> without changes on the their side.
>> If this is the case, I will remove these comments.
>>
>> Cheers
>>
>> Martin
>>
>>
>> --
>> Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
>
>
>
>
>-- 
>Olivier Lamy
>http://twitter.com/olamy | http://linkedin.com/in/olamy

-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Re: RepositorySessionFactory injected

Posted by Olivier Lamy <ol...@apache.org>.
Hi
Well I was expecting users to be able to configure this via ui (i.e
dynamically) not only via spring so the comment.
But never got time to finish that :-)


On 29 August 2017 at 01:59, Martin Stockhammer <ma...@apache.org> wrote:

> Hi,
>
> I stumbled about some fixme comments on RepositorySessionFactory injection
> fields:
> FIXME: this could be multiple implementations and needs to be configured.
>
> Are these still relevant? As I understand there is a
> RepositorySessionFactoryBean that selects the factory based on
> configuration.  And the injected fields get the right implementation
> without changes on the their side.
> If this is the case, I will remove these comments.
>
> Cheers
>
> Martin
>
>
> --
> Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.




-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy