You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphere.io> on 2013/12/13 21:01:48 UTC

Review Request 16250: Moved millisecond multiplication to do only once.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16250/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos-git


Description
-------

Moved millisecond multiplication to do only once.

The view multiples Task timestamps by 1000 to get milliseconds all over
the place. Do that multiplication only once to save multiplication in
the most frequent loops.


Diffs
-----

  src/webui/master/static/framework.html bf7e0207486cf1e6cdd330a6faaf111444565248 
  src/webui/master/static/js/controllers.js 16ba3e2f9f1bf5102be6de7988d2ad8496cc3226 

Diff: https://reviews.apache.org/r/16250/diff/


Testing
-------


Thanks,

Ross Allen

Re: Review Request 16250: Moved millisecond multiplication to do only once.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16250/#review30373
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Dec. 13, 2013, 8:01 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16250/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 8:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Moved millisecond multiplication to do only once.
> 
> The view multiples Task timestamps by 1000 to get milliseconds all over
> the place. Do that multiplication only once to save multiplication in
> the most frequent loops.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/framework.html bf7e0207486cf1e6cdd330a6faaf111444565248 
>   src/webui/master/static/js/controllers.js 16ba3e2f9f1bf5102be6de7988d2ad8496cc3226 
> 
> Diff: https://reviews.apache.org/r/16250/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ross Allen
> 
>