[GitHub] mdeuser commented on a change in pull request #388: Save Code Associated with Blackbox Actions

[GitBox <gi...@apache.org>]

mdeuser commented on a change in pull request #388: Save Code Associated with Blackbox Actions
URL: https://github.com/apache/incubator-openwhisk-cli/pull/388#discussion_r238331384
 
 

 ##########
 File path: commands/action.go
 ##########
 @@ -692,7 +692,7 @@ func saveCode(action whisk.Action, filename string) (err error) {
 	exec = *action.Exec
 	runtime = strings.Split(exec.Kind, ":")[0]
 
-	if strings.ToLower(runtime) == BLACKBOX {
+	if strings.ToLower(runtime) == BLACKBOX && exec.Code == nil && *exec.Binary == false {
 
 Review comment:
   thanks.. that clarified it for me. the *save* operation will write out some binary file.  the exact specification of that binary is up to the developer to know and treat it accordingly.
   
   i suppose the `else` just following this check is really not needed..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services