You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by samratbandgar <gi...@git.apache.org> on 2017/09/06 21:29:10 UTC
[GitHub] nifi pull request #2132: NIFI-4359 Based on field node type, whether value n...
GitHub user samratbandgar opened a pull request:
https://github.com/apache/nifi/pull/2132
NIFI-4359 Based on field node type, whether value node or not, fetching the value of field.
Based on field node type, whether it's value node or not, fetching the value of field.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samratbandgar/nifi NIFI-4359
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2132
----
commit ea84dbbe1fd96e1bd4da9e71eb9ef710feec3178
Author: Samrat Bandgar <sa...@gmail.com>
Date: 2017-09-06T21:05:36Z
NIFI-4359
Based on field node type, whether value node or not, fetching the value of field.
----
---
[GitHub] nifi pull request #2132: NIFI-4359 Based on field node type, whether value n...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2132#discussion_r144077813
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java ---
@@ -37,6 +37,7 @@
import java.util.Set;
import java.util.UUID;
import java.util.concurrent.atomic.AtomicReference;
+import org.apache.commons.lang.StringEscapeUtils;
--- End diff --
All other NiFi code that uses StringEscapeUtils refers to the Commons Lang 3 class `org.apache.commons.lang3.StringEscapeUtils`
---
[GitHub] nifi pull request #2132: NIFI-4359 Based on field node type, whether value n...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2132#discussion_r144078102
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java ---
@@ -508,7 +509,12 @@ private String generateInsert(final JsonNode rootNode, final Map<String, String>
*
*/
protected static String createSqlStringValue(final JsonNode fieldNode, final Integer colSize, final int sqlType) {
- String fieldValue = fieldNode.asText();
+ String fieldValue;
--- End diff --
Can you add unit test(s) to TestConvertJSONToSQL to cover this improvement? The sample data in the Jira would make an excellent unit test :)
---