You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@clerezza.apache.org by mi...@apache.org on 2010/06/02 16:13:41 UTC
svn commit: r950571 -
/incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
Author: mir
Date: Wed Jun 2 14:13:40 2010
New Revision: 950571
URL: http://svn.apache.org/viewvc?rev=950571&view=rev
Log:
added additional com.sun packages to 'org.osgi.framework.system.packages.extra'
Modified:
incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
Modified: incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
URL: http://svn.apache.org/viewvc/incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java?rev=950571&r1=950570&r2=950571&view=diff
==============================================================================
--- incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java (original)
+++ incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java Wed Jun 2 14:13:40 2010
@@ -254,9 +254,12 @@ public class Main implements BundleActiv
configProps.put("org.osgi.service.http.port", port);
}
configProps.put("org.osgi.framework.system.packages.extra",
- "sun.rmi.server;sun.rmi.transport;sun.rmi.transport.tcp;" +
- "sun.rmi.registry;com.sun.jndi.rmi.registry;sun.io;" +
- "com.sun.jmx;sun.misc;");
+ "sun.rmi.server;sun.rmi.transport;sun.rmi.transport.tcp;"
+ + "sun.rmi.registry;com.sun.jndi.rmi.registry;"
+ + "sun.io;"
+ + "com.sun.jmx;"
+ + "sun.misc;"
+ + "com.sun.net.ssl.internal.ssl;com.sun.net.ssl");
configProps.put("org.ops4j.pax.url.mvn.repositories", getCommaSeparatedListOfMavenRepos());
Re: svn commit: r950571 - /incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
Posted by Reto Bachmann-Gmuer <re...@trialox.org>.
With CLEREZZA-229 I removed setting org.osgi.framework.system.packages.extra
altogether. Thanks to this it can be set via the -D java option if an
instance is running with bundles that need it. If any clerezza bundles turns
out to need it we might re-add it in a way to still keep the existing system
property set via -D.
Cheers,
reto
On Fri, Jun 4, 2010 at 9:34 AM, André Dietisheim <
andre.dietisheim@trialox.org> wrote:
> Hi Reto
>
> I am the author of this 'enhancement'.
> I completely agree with you, that it's not ideal to include com.sun.*
> packages, because it enforces a sun jdk. On the other hand the requirements
> are not in our hands and we could only correct'em by writing (and
> submitting) a patch to these 3rd party libs.
>
> The reason behind it is that we need a 3rd party lib, that allows us to
> import users from the wwf nz ldap. I tried 2 frameworks (spring ldap and
> openldap java API). Bot have dependencies to com.sun.* packages - they both
> seem to directly use sun packages. It looks like we have no choice here or
> we'd decide to write a patch that hides the com.sun.*-classes behind an
> interface with interchangeable (optional) implementations.
>
> Cheers
> André
>
>
> On 06/03/2010 02:36 PM, Reto Bachmann-Gmuer wrote:
>
>> Hi Manuel
>>
>> On http://java.sun.com/products/jdk/faq/faq-sun-packages.html I read:
>>
>> "In general, writing java programs that rely on sun.* is risky: they
>> are not portable, and are not supported. "
>>
>> I think we should remove the sun dependencies. Why did you add this
>> ssl dependency? Would the BouncyCastleProvider be an open source
>> alternative?
>>
>> Cheers,
>> reto
>>
>>
>> On Wed, Jun 2, 2010 at 4:13 PM,<mi...@apache.org> wrote:
>>
>>
>>> Author: mir
>>> Date: Wed Jun 2 14:13:40 2010
>>> New Revision: 950571
>>>
>>> URL: http://svn.apache.org/viewvc?rev=950571&view=rev
>>> Log:
>>> added additional com.sun packages to
>>> 'org.osgi.framework.system.packages.extra'
>>>
>>> Modified:
>>>
>>> incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
>>>
>>> Modified:
>>> incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
>>> URL:
>>> http://svn.apache.org/viewvc/incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java?rev=950571&r1=950570&r2=950571&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
>>> (original)
>>> +++
>>> incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
>>> Wed Jun 2 14:13:40 2010
>>> @@ -254,9 +254,12 @@ public class Main implements BundleActiv
>>> configProps.put("org.osgi.service.http.port",
>>> port);
>>> }
>>>
>>> configProps.put("org.osgi.framework.system.packages.extra",
>>> -
>>> "sun.rmi.server;sun.rmi.transport;sun.rmi.transport.tcp;" +
>>> -
>>> "sun.rmi.registry;com.sun.jndi.rmi.registry;sun.io;" +
>>> - "com.sun.jmx;sun.misc;");
>>> +
>>> "sun.rmi.server;sun.rmi.transport;sun.rmi.transport.tcp;"
>>> + +
>>> "sun.rmi.registry;com.sun.jndi.rmi.registry;"
>>> + + "sun.io;"
>>> + + "com.sun.jmx;"
>>> + + "sun.misc;"
>>> + +
>>> "com.sun.net.ssl.internal.ssl;com.sun.net.ssl");
>>> configProps.put("org.ops4j.pax.url.mvn.repositories",
>>> getCommaSeparatedListOfMavenRepos());
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>
Re: svn commit: r950571 - /incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
Posted by André Dietisheim <an...@trialox.org>.
Hi Reto
I am the author of this 'enhancement'.
I completely agree with you, that it's not ideal to include com.sun.*
packages, because it enforces a sun jdk. On the other hand the
requirements are not in our hands and we could only correct'em by
writing (and submitting) a patch to these 3rd party libs.
The reason behind it is that we need a 3rd party lib, that allows us to
import users from the wwf nz ldap. I tried 2 frameworks (spring ldap and
openldap java API). Bot have dependencies to com.sun.* packages - they
both seem to directly use sun packages. It looks like we have no choice
here or we'd decide to write a patch that hides the com.sun.*-classes
behind an interface with interchangeable (optional) implementations.
Cheers
André
On 06/03/2010 02:36 PM, Reto Bachmann-Gmuer wrote:
> Hi Manuel
>
> On http://java.sun.com/products/jdk/faq/faq-sun-packages.html I read:
>
> "In general, writing java programs that rely on sun.* is risky: they
> are not portable, and are not supported. "
>
> I think we should remove the sun dependencies. Why did you add this
> ssl dependency? Would the BouncyCastleProvider be an open source
> alternative?
>
> Cheers,
> reto
>
>
> On Wed, Jun 2, 2010 at 4:13 PM,<mi...@apache.org> wrote:
>
>> Author: mir
>> Date: Wed Jun 2 14:13:40 2010
>> New Revision: 950571
>>
>> URL: http://svn.apache.org/viewvc?rev=950571&view=rev
>> Log:
>> added additional com.sun packages to 'org.osgi.framework.system.packages.extra'
>>
>> Modified:
>> incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
>>
>> Modified: incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
>> URL: http://svn.apache.org/viewvc/incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java?rev=950571&r1=950570&r2=950571&view=diff
>> ==============================================================================
>> --- incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java (original)
>> +++ incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java Wed Jun 2 14:13:40 2010
>> @@ -254,9 +254,12 @@ public class Main implements BundleActiv
>> configProps.put("org.osgi.service.http.port", port);
>> }
>> configProps.put("org.osgi.framework.system.packages.extra",
>> - "sun.rmi.server;sun.rmi.transport;sun.rmi.transport.tcp;" +
>> - "sun.rmi.registry;com.sun.jndi.rmi.registry;sun.io;" +
>> - "com.sun.jmx;sun.misc;");
>> + "sun.rmi.server;sun.rmi.transport;sun.rmi.transport.tcp;"
>> + + "sun.rmi.registry;com.sun.jndi.rmi.registry;"
>> + + "sun.io;"
>> + + "com.sun.jmx;"
>> + + "sun.misc;"
>> + + "com.sun.net.ssl.internal.ssl;com.sun.net.ssl");
>> configProps.put("org.ops4j.pax.url.mvn.repositories", getCommaSeparatedListOfMavenRepos());
>>
>>
>>
>>
>>
>>
Re: svn commit: r950571 - /incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
Posted by Reto Bachmann-Gmuer <re...@trialox.org>.
Hi Manuel
On http://java.sun.com/products/jdk/faq/faq-sun-packages.html I read:
"In general, writing java programs that rely on sun.* is risky: they
are not portable, and are not supported. "
I think we should remove the sun dependencies. Why did you add this
ssl dependency? Would the BouncyCastleProvider be an open source
alternative?
Cheers,
reto
On Wed, Jun 2, 2010 at 4:13 PM, <mi...@apache.org> wrote:
> Author: mir
> Date: Wed Jun 2 14:13:40 2010
> New Revision: 950571
>
> URL: http://svn.apache.org/viewvc?rev=950571&view=rev
> Log:
> added additional com.sun packages to 'org.osgi.framework.system.packages.extra'
>
> Modified:
> incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
>
> Modified: incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java
> URL: http://svn.apache.org/viewvc/incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java?rev=950571&r1=950570&r2=950571&view=diff
> ==============================================================================
> --- incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java (original)
> +++ incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.launcher.storageless.parent/org.apache.clerezza.platform.launcher.storageless/src/main/java/org/apache/clerezza/platform/launcher/Main.java Wed Jun 2 14:13:40 2010
> @@ -254,9 +254,12 @@ public class Main implements BundleActiv
> configProps.put("org.osgi.service.http.port", port);
> }
> configProps.put("org.osgi.framework.system.packages.extra",
> - "sun.rmi.server;sun.rmi.transport;sun.rmi.transport.tcp;" +
> - "sun.rmi.registry;com.sun.jndi.rmi.registry;sun.io;" +
> - "com.sun.jmx;sun.misc;");
> + "sun.rmi.server;sun.rmi.transport;sun.rmi.transport.tcp;"
> + + "sun.rmi.registry;com.sun.jndi.rmi.registry;"
> + + "sun.io;"
> + + "com.sun.jmx;"
> + + "sun.misc;"
> + + "com.sun.net.ssl.internal.ssl;com.sun.net.ssl");
> configProps.put("org.ops4j.pax.url.mvn.repositories", getCommaSeparatedListOfMavenRepos());
>
>
>
>
>