[jira] Commented: (HADOOP-4993) chukwa agent startup should be more modular

["Ari Rabkin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661912#action_12661912 ] 

Ari Rabkin commented on HADOOP-4993:
------------------------------------

 It's hard to write unit tests for ChukwaAgent, because there's no way to suppress the default configuration mechanism and pass the Agent a hardcoded test configuration.  I think the fix is to create another constructor, that takes a Configuration explicitly instead of reading a file.  This will make it easy to test the configuration and startup mechanisms. Those tests should probably appeaer with this JIRA.

And as long as we're fixing the configuration mechanism, we shouldn't read both initial_adaptors and a checkpoint.  Initial_adaptors should only be used if there isn't a checkpoint.


> chukwa agent startup should be more modular
> -------------------------------------------
>
>                 Key: HADOOP-4993
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4993
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/chukwa
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>
> Right now, the Chukwa Agent configuration and startup code is complex and tangled. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.