You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/20 15:04:45 UTC
[GitHub] [hadoop-ozone] elek commented on a change in pull request #834: HDDS-3101. Depend on lightweight ConfigurationSource interface instead of Hadoop Configuration
elek commented on a change in pull request #834:
URL: https://github.com/apache/hadoop-ozone/pull/834#discussion_r411452883
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
##########
@@ -114,16 +113,20 @@
// A lock that is held during container creation.
private final AutoCloseableLock containerCreationLock;
- public KeyValueHandler(Configuration config, String datanodeId,
+ public KeyValueHandler(ConfigurationSource config, String datanodeId,
ContainerSet contSet, VolumeSet volSet, ContainerMetrics metrics,
Consumer<ContainerReplicaProto> icrSender) {
super(config, datanodeId, contSet, volSet, metrics, icrSender);
containerType = ContainerType.KeyValueContainer;
blockManager = new BlockManagerImpl(config);
chunkManager = ChunkManagerFactory.createChunkManager(config);
- volumeChoosingPolicy = ReflectionUtils.newInstance(conf.getClass(
- HDDS_DATANODE_VOLUME_CHOOSING_POLICY, RoundRobinVolumeChoosingPolicy
- .class, VolumeChoosingPolicy.class), conf);
+ try {
+ volumeChoosingPolicy = conf.getClass(
+ HDDS_DATANODE_VOLUME_CHOOSING_POLICY, RoundRobinVolumeChoosingPolicy
+ .class, VolumeChoosingPolicy.class).newInstance();
Review comment:
That's true, I didn't restore the support of this feature (for the sake of simplicity).
Long term I would implement a `@Configurable` annotation instead of `Configurable` interface and inject configuration values instead of annotations if required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org