You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/07/07 16:30:29 UTC

[GitHub] [openwhisk-website] mrutkows opened a new pull request #438: Update README with recommended versions for website build dependencies)

mrutkows opened a new pull request #438:
URL: https://github.com/apache/openwhisk-website/pull/438


   Several ruby libraries updated their dependent versions of base ruby recently and caused incompatibilities when trying to run/build the jekyll website.  I thought it necessary to provide better guidance for new contribs. on what versions we recommend to have a working setup if they come to us with older versions of Ruby (for example) installed (else they would see the errors I encountered and unraveling them was not fun).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] mrutkows commented on a change in pull request #438: Update README with recommended versions for website build dependencies

Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #438:
URL: https://github.com/apache/openwhisk-website/pull/438#discussion_r451195292



##########
File path: README.md
##########
@@ -27,8 +27,9 @@ Apache OpenWhisk is a cloud-first distributed event-based programming service. I
 
 ### Install Prerequisites
 
-- Download and install Node.js: see [https://nodejs.org/](https://nodejs.org/)
-- Download and install Ruby: see [https://www.ruby-lang.org/en/documentation/installation/](https://www.ruby-lang.org/en/documentation/installation/)
+- Download and install Node.js (recommend v10 LTS): see [https://nodejs.org/](https://nodejs.org/

Review comment:
       Fixed missing parens, good catch!
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] pritidesai commented on a change in pull request #438: Update README with recommended versions for website build dependencies

Posted by GitBox <gi...@apache.org>.
pritidesai commented on a change in pull request #438:
URL: https://github.com/apache/openwhisk-website/pull/438#discussion_r451597347



##########
File path: README.md
##########
@@ -27,8 +27,9 @@ Apache OpenWhisk is a cloud-first distributed event-based programming service. I
 
 ### Install Prerequisites
 
-- Download and install Node.js: see [https://nodejs.org/](https://nodejs.org/)
-- Download and install Ruby: see [https://www.ruby-lang.org/en/documentation/installation/](https://www.ruby-lang.org/en/documentation/installation/)
+- Download and install Node.js (recommend v10 LTS): see [https://nodejs.org/](https://nodejs.org/

Review comment:
       thanks @mrutkows 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] pritidesai merged pull request #438: Update README with recommended versions for website build dependencies

Posted by GitBox <gi...@apache.org>.
pritidesai merged pull request #438:
URL: https://github.com/apache/openwhisk-website/pull/438


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] pritidesai commented on a change in pull request #438: Update README with recommended versions for website build dependencies

Posted by GitBox <gi...@apache.org>.
pritidesai commented on a change in pull request #438:
URL: https://github.com/apache/openwhisk-website/pull/438#discussion_r451146878



##########
File path: README.md
##########
@@ -27,8 +27,9 @@ Apache OpenWhisk is a cloud-first distributed event-based programming service. I
 
 ### Install Prerequisites
 
-- Download and install Node.js: see [https://nodejs.org/](https://nodejs.org/)
-- Download and install Ruby: see [https://www.ruby-lang.org/en/documentation/installation/](https://www.ruby-lang.org/en/documentation/installation/)
+- Download and install Node.js (recommend v10 LTS): see [https://nodejs.org/](https://nodejs.org/

Review comment:
       missing `)` in the end here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-website] mrutkows commented on pull request #438: Update README with recommended versions for website build dependencies

Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #438:
URL: https://github.com/apache/openwhisk-website/pull/438#issuecomment-655563900


   @pritidesai tyvm!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org