You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "poorbarcode (via GitHub)" <gi...@apache.org> on 2024/10/21 08:08:18 UTC

[PR] [fix] [proxy] Fix pattern consumer does not work when using Proxy [pulsar]

poorbarcode opened a new pull request, #23489:
URL: https://github.com/apache/pulsar/pull/23489

   ### Motivation
   
   https://github.com/apache/pulsar/pull/22854 added a new method `List<Integer> getExistsPartitions(String topic)`, which depends on the new method `GetTopicsResult.nonPartitionedOrPartitionTopics`, but the author of the PR forgot the change the deserializer of Pulsar-Proxy, which may cause the following issue:
   - Broker respond: `tp-partition-0`
   - Proxy received `tp-partition-0` and recreate a new response that may remove the suffix `-partition-0` to client 
   - Client received `tp`, which without `-partition-0`
     - Client assumed the parition `0` does not exists. 
   
   ### Modifications
   
   Fix the bug
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: x
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix] [proxy] Fix pattern consumer does not work when using Proxy [pulsar]

Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #23489:
URL: https://github.com/apache/pulsar/pull/23489#issuecomment-2425933438

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix] [proxy] Fix pattern consumer does not work when using Proxy [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #23489:
URL: https://github.com/apache/pulsar/pull/23489


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org