[jira] [Updated] (HDFS-5676) fix inconsistent synchronization of CachingStrategy

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HDFS-5676:
---------------------------------------

    Attachment: HDFS-5676.001.patch

also make CachingStrategy immutable.  this makes it easier to reason about the synchronization

> fix inconsistent synchronization of CachingStrategy
> ---------------------------------------------------
>
>                 Key: HDFS-5676
>                 URL: https://issues.apache.org/jira/browse/HDFS-5676
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-5676.001.patch
>
>
> Currently, the synchronization for {{CachingStrategy}} is a little inconsistent.  DFSOutputStream#setDropBehind modifies the strategy object, but there's nothing protecting that object against concurrent use in {{createBlockOutputStream}}.  Similarly, {{DFSInputStream#setDropBehind}} is synchronized, but not all the uses of {{cachingStrategy}} are.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)