You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/02/11 07:42:00 UTC
[GitHub] [shardingsphere-elasticjob] dreamagician opened a new pull request #2051: add executionId to tracing event
dreamagician opened a new pull request #2051:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2051
every execution has a different id, make it easy to group events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #2051: add executionId to tracing event
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #2051:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2051#issuecomment-1047048019
Hi @dreamagician
Could you explain more details about your PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #2051: add executionId to tracing event
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2051:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2051#issuecomment-1036112776
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2051](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2739042) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/9063cd67566520cb22c335a8320ec6b21823a2ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9063cd6) will **decrease** coverage by `0.27%`.
> The diff coverage is `95.52%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2051 +/- ##
============================================
- Coverage 85.22% 84.95% -0.28%
+ Complexity 1882 142 -1740
============================================
Files 281 281
Lines 6133 6141 +8
Branches 732 925 +193
============================================
- Hits 5227 5217 -10
- Misses 571 583 +12
- Partials 335 341 +6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../elasticjob/tracing/event/JobStatusTraceEvent.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9ldmVudC9Kb2JTdGF0dXNUcmFjZUV2ZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...sphere/elasticjob/executor/ElasticJobExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1leGVjdXRvci9lbGFzdGljam9iLWV4ZWN1dG9yLWtlcm5lbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9leGVjdXRvci9FbGFzdGljSm9iRXhlY3V0b3IuamF2YQ==) | `89.69% <86.66%> (-1.71%)` | :arrow_down: |
| [...d/console/controller/search/JobEventRdbSearch.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9jb25zb2xlL2NvbnRyb2xsZXIvc2VhcmNoL0pvYkV2ZW50UmRiU2VhcmNoLmphdmE=) | `83.20% <87.50%> (ø)` | |
| [...sphere/elasticjob/cloud/facade/CloudJobFacade.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2Nsb3VkL2ZhY2FkZS9DbG91ZEpvYkZhY2FkZS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...sticjob/cloud/scheduler/mesos/SchedulerEngine.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9zY2hlZHVsZXIvbWVzb3MvU2NoZWR1bGVyRW5naW5lLmphdmE=) | `92.53% <100.00%> (ø)` | |
| [...ud/scheduler/mesos/TaskLaunchScheduledService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLXNjaGVkdWxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9jbG91ZC9zY2hlZHVsZXIvbWVzb3MvVGFza0xhdW5jaFNjaGVkdWxlZFNlcnZpY2UuamF2YQ==) | `74.16% <100.00%> (ø)` | |
| [...re/elasticjob/tracing/event/JobExecutionEvent.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9ldmVudC9Kb2JFeGVjdXRpb25FdmVudC5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ticjob/tracing/rdb/storage/RDBJobEventStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvc3RvcmFnZS9SREJKb2JFdmVudFN0b3JhZ2UuamF2YQ==) | `81.73% <100.00%> (-0.13%)` | :arrow_down: |
| [...asticjob/lite/internal/schedule/LiteJobFacade.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvTGl0ZUpvYkZhY2FkZS5qYXZh) | `96.29% <100.00%> (ø)` | |
| [.../datasource/DataSourceTracingStorageConverter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi10cmFjaW5nL2VsYXN0aWNqb2ItdHJhY2luZy1yZGIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvdHJhY2luZy9yZGIvZGF0YXNvdXJjZS9EYXRhU291cmNlVHJhY2luZ1N0b3JhZ2VDb252ZXJ0ZXIuamF2YQ==) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9063cd6...2739042](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2051?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] dreamagician commented on pull request #2051: add executionId to tracing event
Posted by GitBox <gi...@apache.org>.
dreamagician commented on pull request #2051:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2051#issuecomment-1047836189
- new field "executionId" added to JobStatusTraceEvents and JobExecutionEvents.
- the executionId generated before ElasticJobExecutor.execute and put into events created during execution.
- new argument added to JobFacade.postJobStatusTraceEvent and it's implements to pass on the executionId.
- in elasticjob-tracing-rdb moudle, new column "execution_id" add for saving the executionId
- column "execution_id" also added to JobEventRdbSearch for select
- some test class modified to adapt new constructor of JobStatusTraceEvents and JobExecutionEvents
- some test class modified to adapt new arguments of JobFacade.postJobStatusTraceEvent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org