You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/06/20 13:24:15 UTC
[PR] akka.net licensing for #3063 [pekko]
pjfanning opened a new pull request, #3112:
URL: https://github.com/apache/pekko/pull/3112
relates to #3063 and the code copied from https://github.com/akkadotnet/akka.net/pull/8264
The Benchmark changes in #3063 seem to be different to the akka.net changes so I just concentrated on Hub and HubSpec changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #3112:
URL: https://github.com/apache/pekko/pull/3112#issuecomment-4759349388
thanks @He-Pin @orange-dot - I'll close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #3112:
URL: https://github.com/apache/pekko/pull/3112#issuecomment-4759067322
@orange-dot Thanks for the comment, can you please comment on the related PR too:) 🫶
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #3112:
URL: https://github.com/apache/pekko/pull/3112#discussion_r3446480965
##########
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Hub.scala:
##########
@@ -11,6 +11,13 @@
* Copyright (C) 2015-2022 Lightbend Inc. <https://www.lightbend.com>
*/
+//-----------------------------------------------------------------------
+// <copyright file="Hub.cs" company="Akka.NET Project">
+// Copyright (C) 2009-2022 Lightbend Inc. <http://www.lightbend.com>
+// Copyright (C) 2013-2025 .NET Foundation <https://github.com/akkadotnet/akka.net>
+// </copyright>
+//-----------------------------------------------------------------------
+
Review Comment:
No code is copied from it....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #3112:
URL: https://github.com/apache/pekko/pull/3112#issuecomment-4758310863
> I think I can revert #3063 and redo that again if you think that's a problem, Because I actually not looked into any code.
@He-Pin let's wait. This is not urgent. If @orange-dot could comment here or on #3063 to say that he is happy for his code to be used in Pekko then I'd prefer to keep the code as is. We can avoid having to merge the license and header changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #3112:
URL: https://github.com/apache/pekko/pull/3112#issuecomment-4758349181
revert pr created https://github.com/apache/pekko/pull/3113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #3112:
URL: https://github.com/apache/pekko/pull/3112#issuecomment-4758283258
I think I can revert https://github.com/apache/pekko/pull/3063 and redo that again if you think that's a problem, Because I actually not looked into any code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "orange-dot (via GitHub)" <gi...@apache.org>.
orange-dot commented on PR #3112:
URL: https://github.com/apache/pekko/pull/3112#issuecomment-4759089208
@He-Pin done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #3112:
URL: https://github.com/apache/pekko/pull/3112#issuecomment-4758248154
And the code is not merged yet. The license is belong to @orange-dot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #3112:
URL: https://github.com/apache/pekko/pull/3112#issuecomment-4758228583
The code is not copied from it, just the description from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #3112: akka.net licensing for #3063
URL: https://github.com/apache/pekko/pull/3112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] akka.net licensing for #3063 [pekko]
Posted by "orange-dot (via GitHub)" <gi...@apache.org>.
orange-dot commented on PR #3112:
URL: https://github.com/apache/pekko/pull/3112#issuecomment-4759017331
> > I think I can revert #3063 and redo that again if you think that's a problem, Because I actually not looked into any code.
>
> @He-Pin let's wait. This is not urgent. If @orange-dot could comment here or on #3063 to say that he is happy for his code to be used in Pekko then I'd prefer to keep the code as is. We can avoid having to merge the license and header changes in this PR.
More than happy, please use it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org