You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2021/07/15 11:57:52 UTC
[GitHub] [incubator-pegasus] Shuo-Jia opened a new pull request #781: fix(script): increase the assign-delay time
Shuo-Jia opened a new pull request #781:
URL: https://github.com/apache/incubator-pegasus/pull/781
### What problem does this PR solve? <!--add issue link with summary if exists-->
### What is changed and how does it work?
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] hycdong commented on a change in pull request #781: fix(script): increase the assign-delay time
Posted by GitBox <gi...@apache.org>.
hycdong commented on a change in pull request #781:
URL: https://github.com/apache/incubator-pegasus/pull/781#discussion_r670960967
##########
File path: scripts/pegasus_rolling_update.sh
##########
@@ -123,6 +123,14 @@ if [ $set_ok -ne 1 ]; then
exit 1
fi
+echo "Set lb.assign_delay_ms to 60min..."
Review comment:
I think 60min is too long, I review the log yesterday, it cost 11 minutes to initialization. How about update to 30min?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 merged pull request #781: fix(script): increase the assign-delay time
Posted by GitBox <gi...@apache.org>.
levy5307 merged pull request #781:
URL: https://github.com/apache/incubator-pegasus/pull/781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #781: fix(script): increase the assign-delay time
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #781:
URL: https://github.com/apache/incubator-pegasus/pull/781#discussion_r670984052
##########
File path: scripts/pegasus_rolling_update.sh
##########
@@ -123,6 +123,14 @@ if [ $set_ok -ne 1 ]; then
exit 1
fi
+echo "Set lb.assign_delay_ms to 30min..."
+echo "remote_command -l $pmeta meta.lb.assign_delay_ms 1800000" | ./run.sh shell --cluster $meta_list &>/tmp/$UID.$PID.pegasus.rolling_node.assign_delay_ms
+set_ok=`grep OK /tmp/$UID.$PID.pegasus.rolling_node.assign_delay_ms | wc -l`
+if [ $set_ok -ne 1 ]; then
+ echo "ERROR: set lb.assign_delay_ms to 60min failed"
Review comment:
the log is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 merged pull request #781: fix(script): increase the assign-delay time
Posted by GitBox <gi...@apache.org>.
levy5307 merged pull request #781:
URL: https://github.com/apache/incubator-pegasus/pull/781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 merged pull request #781: fix(script): increase the assign-delay time
Posted by GitBox <gi...@apache.org>.
levy5307 merged pull request #781:
URL: https://github.com/apache/incubator-pegasus/pull/781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Shuo-Jia commented on a change in pull request #781: fix(script): increase the assign-delay time
Posted by GitBox <gi...@apache.org>.
Shuo-Jia commented on a change in pull request #781:
URL: https://github.com/apache/incubator-pegasus/pull/781#discussion_r670983050
##########
File path: scripts/pegasus_rolling_update.sh
##########
@@ -123,6 +123,14 @@ if [ $set_ok -ne 1 ]; then
exit 1
fi
+echo "Set lb.assign_delay_ms to 60min..."
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org