You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rawwar (via GitHub)" <gi...@apache.org> on 2024/02/15 05:38:58 UTC
[PR] Fix remaining D401 checks [airflow]
rawwar opened a new pull request, #37434:
URL: https://github.com/apache/airflow/pull/37434
fixes #37256
Fixes D401 checks for rest of remaining modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix remaining D401 checks [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #37434:
URL: https://github.com/apache/airflow/pull/37434#discussion_r1490733818
##########
pyproject.toml:
##########
Review Comment:
Could you also remove this comment?
https://github.com/apache/airflow/blob/2a0f3d29805d121429c9788bca32b57858136dc1/pyproject.toml#L1302-L1304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix remaining D401 checks [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar closed pull request #37434: Fix remaining D401 checks
URL: https://github.com/apache/airflow/pull/37434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix remaining D401 checks [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #37434:
URL: https://github.com/apache/airflow/pull/37434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix remaining D401 checks [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #37434:
URL: https://github.com/apache/airflow/pull/37434#discussion_r1490426862
##########
airflow/providers/weaviate/hooks/weaviate.py:
##########
@@ -675,7 +675,7 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool:
def _delete_objects(self, uuids: Collection, class_name: str, retry_attempts_per_object: int = 5):
"""
- Helper function for `create_or_replace_objects()` to delete multiple objects.
+ Act as a helper function for `create_or_replace_objects()` to delete multiple objects.
Review Comment:
Thanks. I will do that. I also did this in few other places. I'll take care of this issue there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix remaining D401 checks [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #37434:
URL: https://github.com/apache/airflow/pull/37434#discussion_r1490416430
##########
airflow/providers/weaviate/hooks/weaviate.py:
##########
@@ -675,7 +675,7 @@ def object_exists(self, uuid: str | UUID, **kwargs) -> bool:
def _delete_objects(self, uuids: Collection, class_name: str, retry_attempts_per_object: int = 5):
"""
- Helper function for `create_or_replace_objects()` to delete multiple objects.
+ Act as a helper function for `create_or_replace_objects()` to delete multiple objects.
Review Comment:
This can probably be more descriprive to what this function actually does. The helper function aspect can be put in the second line instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix remaining D401 checks [airflow]
Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #37434:
URL: https://github.com/apache/airflow/pull/37434#discussion_r1490748237
##########
pyproject.toml:
##########
Review Comment:
Removed it. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org