You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "sammu97 (via GitHub)" <gi...@apache.org> on 2025/03/14 16:37:25 UTC
[PR] NIFI-14367 Removed casting to BufferedInputStream in PublishKafka [nifi]
sammu97 opened a new pull request, #9804:
URL: https://github.com/apache/nifi/pull/9804
- This PR aims to fix issues arising when the Kafka Publisher process attempts to infer a schema from a Json Payload greater than 1 MB. This is because the mark() limit set on the current input stream is statically set at 1000000. This fix removes to casting of the Input Stream to a Buffer Input Stream, thus omitting the dependency on the mark() function.
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-14367](https://issues.apache.org/jira/browse/NIFI-14367)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 21
### Licensing
- [X] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [X] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [X] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14367 Removed casting to BufferedInputStream in PublishKafka [nifi]
Posted by "sammu97 (via GitHub)" <gi...@apache.org>.
sammu97 commented on PR #9804:
URL: https://github.com/apache/nifi/pull/9804#issuecomment-2729489471
Great @pvillard31 , thank you and looking forward to having this released 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14367 Removed casting to BufferedInputStream in PublishKafka [nifi]
Posted by "sammu97 (via GitHub)" <gi...@apache.org>.
sammu97 commented on PR #9804:
URL: https://github.com/apache/nifi/pull/9804#issuecomment-2725985134
Hi @pvillard31 , I've added 2 tests for the KafkaRecordConverter, however am finding it difficult to mock a **RecordStreamKafkaRecordConverter** and **RecordWrapperStreamKafkaRecordConverter** due to the **RecordSetWriterFactory** and **RecordReaderFactory** objects needed. Would appreciate some guidance here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14367 Removed casting to BufferedInputStream in PublishKafka [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #9804:
URL: https://github.com/apache/nifi/pull/9804#issuecomment-2750973890
Closing this pull request in favor of #9807 to keep clean the list of PRs. Will try to get attention on it from a reviewer/committer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14367 Removed casting to BufferedInputStream in PublishKafka [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #9804: NIFI-14367 Removed casting to BufferedInputStream in PublishKafka
URL: https://github.com/apache/nifi/pull/9804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14367 Removed casting to BufferedInputStream in PublishKafka [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #9804:
URL: https://github.com/apache/nifi/pull/9804#issuecomment-2729457788
Hi @sammu97 - thanks for adding the tests! I did a larger refactor of the Kafka components in this PR #9807 and I retained your commit that is adding the tests to confirm that it's working with the refactored approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14367 Removed casting to BufferedInputStream in PublishKafka [nifi]
Posted by "sammu97 (via GitHub)" <gi...@apache.org>.
sammu97 commented on PR #9804:
URL: https://github.com/apache/nifi/pull/9804#issuecomment-2725468932
Hi @pvillard31 , sure will do. Will need to give some thought about how to best go about testing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14367 Removed casting to BufferedInputStream in PublishKafka [nifi]
Posted by "sammu97 (via GitHub)" <gi...@apache.org>.
sammu97 commented on PR #9804:
URL: https://github.com/apache/nifi/pull/9804#issuecomment-2726480405
Hi @pvillard31 , I have added further tests for all KafkaRecordConverter classes, let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org