You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/06/26 03:28:43 UTC
[james-project] 03/28: JAMES-2794 Demonstrate reprocessing was
broken on top of RabbitMQ mailQueue
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 49939ce407d60e24b04efea3da430af3972a7789
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Mon Jun 17 13:32:02 2019 +0700
JAMES-2794 Demonstrate reprocessing was broken on top of RabbitMQ mailQueue
Because the reprocessed mail had the same name, it was assumed to had been already pr
---
.../james/RabbitMQJamesServerReprocessingTest.java | 94 ++++++++++++++++++++++
1 file changed, 94 insertions(+)
diff --git a/server/container/guice/cassandra-rabbitmq-guice/src/test/java/org/apache/james/RabbitMQJamesServerReprocessingTest.java b/server/container/guice/cassandra-rabbitmq-guice/src/test/java/org/apache/james/RabbitMQJamesServerReprocessingTest.java
new file mode 100644
index 0000000..bc62128
--- /dev/null
+++ b/server/container/guice/cassandra-rabbitmq-guice/src/test/java/org/apache/james/RabbitMQJamesServerReprocessingTest.java
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.james;
+
+import static io.restassured.config.ParamConfig.UpdateStrategy.REPLACE;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.apache.james.mailrepository.api.MailRepositoryUrl;
+import org.apache.james.modules.RabbitMQExtension;
+import org.apache.james.modules.TestJMAPServerModule;
+import org.apache.james.modules.protocols.SmtpGuiceProbe;
+import org.apache.james.utils.MailRepositoryProbeImpl;
+import org.apache.james.utils.SMTPMessageSender;
+import org.apache.james.utils.WebAdminGuiceProbe;
+import org.apache.james.webadmin.WebAdminConfiguration;
+import org.apache.james.webadmin.WebAdminUtils;
+import org.awaitility.Awaitility;
+import org.awaitility.Duration;
+import org.awaitility.core.ConditionFactory;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.restassured.RestAssured;
+import io.restassured.config.ParamConfig;
+import io.restassured.parsing.Parser;
+import io.restassured.specification.RequestSpecification;
+
+class RabbitMQJamesServerReprocessingTest {
+ private static final ConditionFactory AWAIT = Awaitility.await().atMost(Duration.ONE_MINUTE);
+ private static final MailRepositoryUrl SENDER_DENIED = MailRepositoryUrl.from("cassandra://var/mail/sender-denied/");
+ private RabbitMQExtension rabbitMQExtension = new RabbitMQExtension();
+ private RequestSpecification webAdminApi;
+
+ @RegisterExtension
+ JamesServerExtension jamesServerExtension = CassandraRabbitMQJamesServerFixture
+ .baseExtensionBuilder(rabbitMQExtension)
+ .server(configuration -> GuiceJamesServer
+ .forConfiguration(configuration)
+ .combineWith(CassandraRabbitMQJamesServerMain.MODULES)
+ .overrideWith(new TestJMAPServerModule(10))
+ .overrideWith(binder -> binder.bind(WebAdminConfiguration.class).toInstance(WebAdminConfiguration.TEST_CONFIGURATION))
+ .overrideWith(JmapJamesServerContract.DOMAIN_LIST_CONFIGURATION_MODULE))
+ .build();
+
+ @BeforeEach
+ void setUp(GuiceJamesServer server) {
+ RestAssured.defaultParser = Parser.JSON;
+ webAdminApi = WebAdminUtils.spec(server.getProbe(WebAdminGuiceProbe.class).getWebAdminPort())
+ .config(WebAdminUtils.defaultConfig()
+ .paramConfig(new ParamConfig(REPLACE, REPLACE, REPLACE)));
+ }
+
+ @Disabled("JAMES-2733 Reprocessing is broken for RabbitMQ mailQueue - the reprocessed mail name is preserved and" +
+ " is thus considered deleted.")
+ @Test
+ void reprocessingADeniedMailShouldNotLooseIt(GuiceJamesServer server) throws Exception {
+ new SMTPMessageSender("other.com")
+ .connect("127.0.0.1", server.getProbe(SmtpGuiceProbe.class).getSmtpPort())
+ .sendMessage("denied@other.com", "any@domain.tld");
+
+ MailRepositoryProbeImpl mailRepositoryProbe = server.getProbe(MailRepositoryProbeImpl.class);
+ AWAIT.until(() -> mailRepositoryProbe.listMailKeys(SENDER_DENIED).size() == 1);
+
+ String taskId = webAdminApi
+ .param("action", "reprocess")
+ .patch("/mailRepositories/var%2Fmail%2Fsender-denied/mails")
+ .jsonPath()
+ .get("taskId");
+
+ webAdminApi.get("/tasks/" + taskId + "/await");
+
+ AWAIT.until(() -> mailRepositoryProbe.listMailKeys(SENDER_DENIED).size() == 1);
+ assertThat(mailRepositoryProbe.listMailKeys(SENDER_DENIED)).hasSize(1);
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org