[GitHub] [flink] CrynetLogistics commented on a change in pull request #17913: [FLINK-24227][connectors] Async Base Sink Hotfix - Introduced maxRecordSizeInBytes and changed the behaviour of flushOnBufferSizeInBytes

[GitBox <gi...@apache.org>]

CrynetLogistics commented on a change in pull request #17913:
URL: https://github.com/apache/flink/pull/17913#discussion_r756958009



##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -310,8 +309,32 @@ private void flush() {
 
         inFlightRequestsCount++;
         submitRequestEntries(batch, requestResult);
-        numRecordsOutCounter.inc(batchSize);
+    }
+
+    /**
+     * Creates the next batch of request entries while respecting the {@code maxBatchSize} and
+     * {@code flushOnBufferSizeBytes}. Also adds these to the metrics counters.

Review comment:
       agh! my search didn't match this since it had no "In". Thanks for this one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org