You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/20 03:04:13 UTC
[GitHub] [incubator-nuttx-testing] liuguo09 opened a new pull request #16:
Add xtensa esp32 boards build support
liuguo09 opened a new pull request #16: Add xtensa esp32 boards build support
URL: https://github.com/apache/incubator-nuttx-testing/pull/16
1. Add xtensa esp32 gcc toolchain
2. Add xtensa esp32 boards into testlist
Note nuttx and apps github action workflows also need update accordingly:
1. docker image updated with xtensa toolchain firstly
2. use 'mips-riscv-x86-xtensa' instead of 'mips-riscv-x86' in matrix boards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #16: Add xtensa esp32 boards build support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 boards build support
URL: https://github.com/apache/incubator-nuttx-testing/pull/16#discussion_r395423947
##########
File path: testlist/mips-riscv-x86-xtensa.dat
##########
@@ -5,3 +5,5 @@
-nr5m100-nexys4:nsh
/x86
+
+/xtensa
Review comment:
Should we move the change to:
https://github.com/apache/incubator-nuttx-testing/blob/master/testlist/full.dat
since xtensa-esp32-gcc-toolchain is just used for the nightly build.
So we can enable esp32 step by step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] liuguo09 commented on issue #16: Add
xtensa esp32 boards build support
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #16: Add xtensa esp32 boards build support
URL: https://github.com/apache/incubator-nuttx-testing/pull/16#issuecomment-601506539
Take care to merge the change since github action docker image and matrix boards should be updated synchronously.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in
pull request #16: Add xtensa esp32 boards build support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #16: Add xtensa esp32 boards build support
URL: https://github.com/apache/incubator-nuttx-testing/pull/16#discussion_r395423947
##########
File path: testlist/mips-riscv-x86-xtensa.dat
##########
@@ -5,3 +5,5 @@
-nr5m100-nexys4:nsh
/x86
+
+/xtensa
Review comment:
Should we move the change to:
https://github.com/apache/incubator-nuttx-testing/blob/master/testlist/full.dat
since xtensa-esp32-gcc-toolchain is just used for the nightly build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #16:
Add xtensa esp32 boards build support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #16: Add xtensa esp32 boards build support
URL: https://github.com/apache/incubator-nuttx-testing/pull/16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] liuguo09 commented on a change in pull
request #16: Add xtensa esp32 boards build support
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #16: Add xtensa esp32 boards build support
URL: https://github.com/apache/incubator-nuttx-testing/pull/16#discussion_r395425971
##########
File path: testlist/mips-riscv-x86-xtensa.dat
##########
@@ -5,3 +5,5 @@
-nr5m100-nexys4:nsh
/x86
+
+/xtensa
Review comment:
You are right. Firstly enable xtensa esp32 boards build in full testlit done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-testing] masayuki2009 commented on issue #16: Add
xtensa esp32 boards build support
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #16: Add xtensa esp32 boards build support
URL: https://github.com/apache/incubator-nuttx-testing/pull/16#issuecomment-601514544
It looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services