You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/30 21:30:04 UTC
[GitHub] [tvm] tkonolige opened a new pull request #9170: Add cache flush for arm
tkonolige opened a new pull request #9170:
URL: https://github.com/apache/tvm/pull/9170
This PR add a cache flush implementation for ARM. The code was written by @merrymercy for [Tenset](https://github.com/tlc-pack/tenset) to improve accuracy of program measurement. I am just helping getting things upstreamed (with permission).
@junrushao1994 @merrymercy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige edited a comment on pull request #9170: Add cache flush for arm
Posted by GitBox <gi...@apache.org>.
tkonolige edited a comment on pull request #9170:
URL: https://github.com/apache/tvm/pull/9170#issuecomment-931722777
Here is the original commit: [6308379dc71137d1ff8628ab1fb555f7a5770f45](https://github.com/tlc-pack/tenset/commit/6308379dc71137d1ff8628ab1fb555f7a5770f45)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9170: Add cache flush for arm
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9170:
URL: https://github.com/apache/tvm/pull/9170#issuecomment-932679836
Thanks @tkonolige! This is merged :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9170: Add cache flush for arm
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9170:
URL: https://github.com/apache/tvm/pull/9170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #9170: Add cache flush for arm
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #9170:
URL: https://github.com/apache/tvm/pull/9170#issuecomment-931722777
Here is the original commit: 6308379dc71137d1ff8628ab1fb555f7a5770f45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FrozenGene commented on a change in pull request #9170: Add cache flush for arm
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on a change in pull request #9170:
URL: https://github.com/apache/tvm/pull/9170#discussion_r724645397
##########
File path: src/runtime/rpc/rpc_module.cc
##########
@@ -320,18 +320,33 @@ std::shared_ptr<RPCSession> RPCModuleGetSession(Module mod) {
* which leads to lower performance.
*/
inline void CPUCacheFlushImpl(const char* addr, unsigned int len) {
-// TODO(FrozenGene): Support ARM.
Review comment:
Maybe we should leave this TODO as we haven't completed support for arm 32 bits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] FrozenGene commented on pull request #9170: Add cache flush for arm
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on pull request #9170:
URL: https://github.com/apache/tvm/pull/9170#issuecomment-938273787
> Yeah I believe the original author is @FrozenGene
@junrushao1994 @tkonolige Yes. Some background, this is written originally by myself when I developed ansor. However, I found this doesn't have effect on the rasperry pi 3b+ like we gained on x86 at that time. So I don't upload the code to the upstream. @tkonolige Do you test it and find it has effect on your arm devices?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9170: Add cache flush for arm
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9170:
URL: https://github.com/apache/tvm/pull/9170#issuecomment-931721576
Yeah I believe the original author is @FrozenGene
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org