You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Renato Javier Marroquín Mogrovejo (JIRA)" <ji...@apache.org> on 2018/08/25 15:17:00 UTC
[jira] [Commented] (ARROW-3017) [C++] Don't throw exception in
arrow/util/thread-pool.h
[ https://issues.apache.org/jira/browse/ARROW-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592621#comment-16592621 ]
Renato Javier Marroquín Mogrovejo commented on ARROW-3017:
----------------------------------------------------------
Submitted small pr to address this.
Let me know what you think [~wesmckinn]
> [C++] Don't throw exception in arrow/util/thread-pool.h
> -------------------------------------------------------
>
> Key: ARROW-3017
> URL: https://issues.apache.org/jira/browse/ARROW-3017
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.11.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This would indicate that the developer has used the thread pool improperly. I would recommend using {{std::abort}} instead of throwing a {{std::runtime_error}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)