You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/09/02 23:54:32 UTC

[jira] Created: (THRIFT-575) Allow required modifier in method parameters

Allow required modifier in method parameters
--------------------------------------------

                 Key: THRIFT-575
                 URL: https://issues.apache.org/jira/browse/THRIFT-575
             Project: Thrift
          Issue Type: Improvement
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis


This allows a server to reject invalid null values in generated code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-575) Allow required modifier in method parameters

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated THRIFT-575:
----------------------------------

    Attachment: 575.patch

As discussed in THRIFT-562, reverting the part of r665255 that disallows the required keyword in method parameters achieves the desired effect.

Passes the thrift java test suite, and the Cassandra system test suite combined with CASSANDRA-308 patch to add "required" keywords.

> Allow required modifier in method parameters
> --------------------------------------------
>
>                 Key: THRIFT-575
>                 URL: https://issues.apache.org/jira/browse/THRIFT-575
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 575.patch
>
>
> This allows a server to reject invalid null values in generated code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-575) Allow required modifier in method parameters

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-575.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.2

> Allow required modifier in method parameters
> --------------------------------------------
>
>                 Key: THRIFT-575
>                 URL: https://issues.apache.org/jira/browse/THRIFT-575
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.2
>
>         Attachments: 575.patch
>
>
> This allows a server to reject invalid null values in generated code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (THRIFT-575) Allow required modifier in method parameters

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750691#action_12750691 ] 

Jonathan Ellis edited comment on THRIFT-575 at 9/2/09 2:59 PM:
---------------------------------------------------------------

As discussed in THRIFT-562, reverting the part of r665255 that disallows the required keyword in method parameters achieves the desired effect.

Passes the thrift java test suite, and the Cassandra system test suite combined with CASSANDRA-308 patch (308-v2.patch) to add "required" keywords.

      was (Author: jbellis):
    As discussed in THRIFT-562, reverting the part of r665255 that disallows the required keyword in method parameters achieves the desired effect.

Passes the thrift java test suite, and the Cassandra system test suite combined with CASSANDRA-308 patch to add "required" keywords.
  
> Allow required modifier in method parameters
> --------------------------------------------
>
>                 Key: THRIFT-575
>                 URL: https://issues.apache.org/jira/browse/THRIFT-575
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 575.patch
>
>
> This allows a server to reject invalid null values in generated code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.