You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/04 19:11:24 UTC

[GitHub] [iceberg] kbendick commented on a diff in pull request #4638: API / binary compatibility checking tool via revapi gradle plugin

kbendick commented on code in PR #4638:
URL: https://github.com/apache/iceberg/pull/4638#discussion_r865186643


##########
.palantir/revapi.yml:
##########
@@ -0,0 +1,2 @@
+versionOverrides:
+  org.apache.iceberg:iceberg-api:release-base-0.13.0: "0.13.1"

Review Comment:
   Looking through their source code, the `.palantir` directory is hardcoded: https://github.com/kbendick/gradle-revapi/blob/09039d215efbd41e25b6743409a12ceb22ca5d75/src/main/java/com/palantir/gradle/revapi/RevapiPlugin.java#L176-L178
   
   We could either add a comment somewhere in the Gradle build file or possibly try to open a PR upstream.
   
   That said, nobody should have to update the config file manually. It's all done via `gradlew` commands which autogenerates the file and updates it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org