You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 15:31:15 UTC

[GitHub] [airflow] msumit commented on a change in pull request #15795: [WIP] Ability to test connections from UI or API

msumit commented on a change in pull request #15795:
URL: https://github.com/apache/airflow/pull/15795#discussion_r634499659



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -369,6 +369,27 @@ paths:
         '404':
           $ref: '#/components/responses/NotFound'
 
+  /connections/{connection_id}/test:

Review comment:
       I tried that approach as well, but we are relying on the `get_hook` method from the connection class and then calling `test_connection` from the hook. But in some hooks the init looks for a valid connection and errors out if not found ex. https://github.com/apache/airflow/blob/master/airflow/providers/databricks/hooks/databricks.py#L120




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org