You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 03:32:56 UTC

[GitHub] [shardingsphere] zhaojinchao95 opened a new issue, #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

zhaojinchao95 opened a new issue, #21435:
URL: https://github.com/apache/shardingsphere/issues/21435

   \


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1275501396

   > can u tell me how to fix that issue #21452
   
   You can see error message : https://github.com/apache/shardingsphere/actions/runs/3218169698/jobs/5275132672


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] DivvSaxena commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1272766357

   can you give me the location of the file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1368212485

   The method are removed, so i will close it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] DivvSaxena commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1273019299

   #21452 made the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] DivvSaxena commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1272747355

   assign


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] DivvSaxena commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1272767882

   and do we have to basically add unit test or do we have to document it or add some description about it please guide


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 closed issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 closed issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)
URL: https://github.com/apache/shardingsphere/issues/21435


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1272838509

   > and do we have to basically add unit test or do we have to document it or add some description about it please guide
   
   Only add unit test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1272749249

   > assign
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] DivvSaxena commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1274090535

   can u tell me how to fix that issue
   #21452 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] DivvSaxena commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1272746818

   will work on it
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 commented on issue #21435: Add unit test for CuratorZookeeperRepository.getRegistryCenterTime(final String key)

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on issue #21435:
URL: https://github.com/apache/shardingsphere/issues/21435#issuecomment-1272839565

   > can you give me the location of the file
   
   https://github.com/apache/shardingsphere/blob/master/mode/type/cluster/repository/provider/zookeeper-curator/src/test/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/CuratorZookeeperRepositoryTest.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org