You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "T Jake Luciani (JIRA)" <ji...@apache.org> on 2010/12/01 21:25:11 UTC

[jira] Commented: (THRIFT-1014) Thrift JavaScript code should use semicolon-terminated statements

    [ https://issues.apache.org/jira/browse/THRIFT-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965830#action_12965830 ] 

T Jake Luciani commented on THRIFT-1014:
----------------------------------------

We will! please contribute.

> Thrift JavaScript code should use semicolon-terminated statements
> -----------------------------------------------------------------
>
>                 Key: THRIFT-1014
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1014
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Compiler, JavaScript - Library
>            Reporter: James Hamlin
>            Priority: Minor
>
> It's good style to terminate all JavaScript statements with a semicolon. Thrift's JavaScript library and generated JavaScript don't use semicolons at all. Beyond the stylistic improvement, fixing up the syntax would make Thrift's JavaScript compatible with certain JavaScript linters, e.g. Google Closure's.
> I have a patch that's about ready if the project will take contributions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.