You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/22 05:43:47 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #5145: [AIRFLOW-4379] Remove duplicate code & Add validation in gcs_to_gcs.py

potiuk commented on a change in pull request #5145: [AIRFLOW-4379] Remove duplicate code & Add validation in gcs_to_gcs.py
URL: https://github.com/apache/airflow/pull/5145#discussion_r277210428
 
 

 ##########
 File path: airflow/contrib/operators/gcs_to_gcs.py
 ##########
 @@ -143,51 +143,50 @@ def execute(self, context):
             google_cloud_storage_conn_id=self.google_cloud_storage_conn_id,
             delegate_to=self.delegate_to
         )
-        log_message = 'Executing copy of gs://{0}/{1} to gs://{2}/{3}'
+
+        if self.destination_bucket is None:
 
 Review comment:
   Please add description of this behaviour to the docstring.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services