[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #6946: [sqla] Handling subquery error

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #6946: [sqla] Handling subquery error
URL: https://github.com/apache/incubator-superset/pull/6946#discussion_r300239904
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -795,6 +795,10 @@ def get_sqla_query(  # sqla
                     'order_desc': True,
                 }
                 result = self.query(subquery_obj)
+
+                if result.status == utils.QueryStatus.FAILED:
+                    raise Exception(result.error_message)
 
 Review comment:
   Let's create a custom exception for this, something like `SupersetSubQueryError`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org