You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/25 02:02:55 UTC

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #485: fix: fatal error reported when run make build in release src

tokers commented on a change in pull request #485:
URL: https://github.com/apache/apisix-ingress-controller/pull/485#discussion_r638401713



##########
File path: Makefile
##########
@@ -21,8 +21,11 @@ RELEASE_SRC = apache-apisix-ingress-controller-${VERSION}-src
 LOCAL_REGISTRY="localhost:5000"
 IMAGE_TAG ?= dev
 
+GITSHA ?= "No-git-module"

Review comment:
       All words in the output of `apisix-ingress-controller version` are in small case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org