[GitHub] [ozone] umamaheswararao commented on a change in pull request #3076: HDDS-6295. EC: Fix unaligned stripe write failure due to length overflow.

[GitBox <gi...@apache.org>]

umamaheswararao commented on a change in pull request #3076:
URL: https://github.com/apache/ozone/pull/3076#discussion_r804383087



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -587,8 +578,17 @@ public static void padBufferToLimit(ByteBuffer buf, int limit) {
     buf.position(limit);
   }
 
-  private boolean isPartialStripe() {
-    return currentBlockGroupLen % (numDataBlks * ecChunkSize) > 0;
+  private boolean isPartialStripe(int stripeSize) {
+    return stripeSize > 0 && stripeSize < numDataBlks * ecChunkSize;
+  }
+
+  private int getCurrentStripeSize() {

Review comment:
       Could you please rename this to getCurrentDataStripeSize?
   Generally we refer stripe size as combination of data+parity. We we need only data.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org