[GitHub] [flink] TisonKun commented on a change in pull request #10320: [FLINK-14948][client] Implement shutDownCluster for MiniClusterClient

[GitBox <gi...@apache.org>]

TisonKun commented on a change in pull request #10320: [FLINK-14948][client] Implement shutDownCluster for MiniClusterClient
URL: https://github.com/apache/flink/pull/10320#discussion_r350578624
 
 

 ##########
 File path: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
 ##########
 @@ -65,9 +65,7 @@ default void close() throws Exception {
 	/**
 	 * Shut down the cluster that this client communicate with.
 	 */
-	default void shutDownCluster() {
-		throw new UnsupportedOperationException();
-	}
+	void shutDownCluster();
 
 Review comment:
   Within Flink scope we implement this method for all cluster client and I think the consensus is that `ClusterClient` is an internal concept at least for now. Besides, every implementation of `ClusterClient` should think of whether or not and how to shut down its associated cluster.
   
   However, although it makes no sense add a default implementation just `throw new UnsupportedOperationException()`, if you insist I can add back such default implementation just for outside implementation pass compiler checking.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services