You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/10 08:16:10 UTC
[GitHub] [shardingsphere] zjcnb opened a new pull request, #20053: Refactor reload SingleTableRule logic when curd single table
zjcnb opened a new pull request, #20053:
URL: https://github.com/apache/shardingsphere/pull/20053
Fixes #19013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #20053: Refactor reload SingleTableRule logic when curd single table
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #20053:
URL: https://github.com/apache/shardingsphere/pull/20053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on pull request #20053: Refactor reload SingleTableRule logic when curd single table
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on PR #20053:
URL: https://github.com/apache/shardingsphere/pull/20053#issuecomment-1210445650
@zjcnb please fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on pull request #20053: Refactor reload SingleTableRule logic when curd single table
Posted by GitBox <gi...@apache.org>.
zjcnb commented on PR #20053:
URL: https://github.com/apache/shardingsphere/pull/20053#issuecomment-1210541672
> @zjcnb please fix it
Ok, i will check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20053: Refactor reload SingleTableRule logic when curd single table
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20053:
URL: https://github.com/apache/shardingsphere/pull/20053#issuecomment-1210624730
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20053?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20053](https://codecov.io/gh/apache/shardingsphere/pull/20053?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ac67003) into [master](https://codecov.io/gh/apache/shardingsphere/commit/54ea873b9572a93cfbce7f7d7c8a20b4860788c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54ea873) will **decrease** coverage by `0.05%`.
> The diff coverage is `48.14%`.
```diff
@@ Coverage Diff @@
## master #20053 +/- ##
============================================
- Coverage 60.67% 60.62% -0.06%
+ Complexity 2416 2414 -2
============================================
Files 3855 3852 -3
Lines 54687 54719 +32
Branches 7660 7669 +9
============================================
- Hits 33182 33174 -8
- Misses 18655 18691 +36
- Partials 2850 2854 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20053?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/binder/statement/dml/InsertStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RtbC9JbnNlcnRTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `95.69% <0.00%> (ø)` | |
| [...a/binder/statement/dml/SelectStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc3RhdGVtZW50L2RtbC9TZWxlY3RTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `67.82% <0.00%> (ø)` | |
| [...e/infra/exception/NoDatabaseSelectedException.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9leGNlcHRpb24vTm9EYXRhYmFzZVNlbGVjdGVkRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../scenario/rulealtered/RuleAlteredJobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iU2NoZWR1bGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ardingsphere/singletable/rule/SingleTableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNpbmdsZS10YWJsZS9zaGFyZGluZ3NwaGVyZS1zaW5nbGUtdGFibGUtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2luZ2xldGFibGUvcnVsZS9TaW5nbGVUYWJsZVJ1bGUuamF2YQ==) | `60.63% <0.00%> (-0.66%)` | :arrow_down: |
| [...dingsphere/proxy/backend/context/ProxyContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb250ZXh0L1Byb3h5Q29udGV4dC5qYXZh) | `60.00% <ø> (ø)` | |
| [...proxy/backend/exception/CircuitBreakException.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGNlcHRpb24vQ2lyY3VpdEJyZWFrRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...backend/exception/ResourceNotExistedException.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGNlcHRpb24vUmVzb3VyY2VOb3RFeGlzdGVkRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...oxy/backend/exception/RuleNotExistedException.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGNlcHRpb24vUnVsZU5vdEV4aXN0ZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...d/exception/TableModifyInTransactionException.java](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9leGNlcHRpb24vVGFibGVNb2RpZnlJblRyYW5zYWN0aW9uRXhjZXB0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/shardingsphere/pull/20053/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org