[jira] Issue Comment Edited: (OFBIZ-3623) XHTML validation errors (framework/widget)

["Blas Rodriguez Somoza (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853284#action_12853284 ] 

Blas Rodriguez Somoza edited comment on OFBIZ-3623 at 4/5/10 12:09 PM:
-----------------------------------------------------------------------

Hello Bilgin

Excuse me, I don't notice the problem.

The double ampersand is needed because every entity in the markup file must be encoded, even if it is inside javascript code.

I'll review the autocompleter code to look for a solution, it should work with encoded and not encoded ampersands.

DONE: The patch attached to issue OFBIZ-3637 contains the solution, it modifies ajaxAutoCompleter to be able to work with ampersands unencoded or encoded (&)

      was (Author: brsomoza):
    Hello Bilgin

Excuse me, I don't notice the problem.

The double ampersand is needed because every entity in the markup file must be encoded, even if it is inside javascript code.

I'll review the autocompleter code to look for a solution, it should work with encoded and not encoded ampersands.

DONE: The patch attached to issue OFBIZ-3637 contains the solution, it modifies ajaxAutoCompleter to be able to work with ampersands unencoded or encoded (&)
  
> XHTML validation errors (framework/widget)
> ------------------------------------------
>
>                 Key: OFBIZ-3623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3623
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Assignee: Adrian Crum
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3623_framework_widget_xhtml.diff, OFBIZ-3623_framework_widget_xhtml_v2.diff
>
>
> XHTML validation errors
>     * Unclosed INPUT
>     * attributes without values (checked, selected, disabled, etc)
>     * attribute values without "
>     * Uppercase tags or attributes.
>     * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <span id="${id}_indicator" style="display: none" class="indicator"><img /></span>
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.