You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/09/13 12:10:33 UTC

[GitHub] [accumulo] cshannon commented on a diff in pull request #2925: Adding CleanZookeeper utility to accumulo admin command

cshannon commented on code in PR #2925:
URL: https://github.com/apache/accumulo/pull/2925#discussion_r969541610


##########
server/base/src/main/java/org/apache/accumulo/server/util/CleanZookeeper.java:
##########
@@ -67,25 +48,26 @@ public static void main(String[] args) {
             String instanceNamePath = root + Constants.ZINSTANCES + "/" + instanceName;
             byte[] id = zk.getData(instanceNamePath);
             if (id != null && !new String(id, UTF_8).equals(context.getInstanceID().canonical())) {
-              try {
-                zk.recursiveDelete(instanceNamePath, NodeMissingPolicy.SKIP);
-              } catch (KeeperException.NoAuthException ex) {
-                log.warn("Unable to delete {}", instanceNamePath);
-              }
+              delete(zk, instanceNamePath);
+              System.out.println("Deleted instance " + instanceName);

Review Comment:
   Thanks for the review, I should be able to push that quick change tomorrow when I get a chance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org