You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/10/20 02:13:33 UTC
[lucene-solr] branch reference_impl_dev updated: @1032 Enable tests.
This is an automated email from the ASF dual-hosted git repository.
markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
The following commit(s) were added to refs/heads/reference_impl_dev by this push:
new b4ca6db @1032 Enable tests.
b4ca6db is described below
commit b4ca6db509c8c9d270a69414f7ad0f94e9c03023
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Mon Oct 19 21:12:22 2020 -0500
@1032 Enable tests.
---
.../src/test/org/apache/solr/handler/admin/InfoHandlerTest.java | 6 +++---
.../org/apache/solr/handler/component/CustomTermsComponentTest.java | 2 +-
.../apache/solr/handler/component/DistributedMLTComponentTest.java | 1 -
.../component/DistributedQueryComponentOptimizationTest.java | 1 -
.../solr/handler/component/DistributedSpellCheckComponentTest.java | 1 -
.../apache/solr/handler/component/TrackingShardHandlerFactory.java | 2 +-
6 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/solr/core/src/test/org/apache/solr/handler/admin/InfoHandlerTest.java b/solr/core/src/test/org/apache/solr/handler/admin/InfoHandlerTest.java
index 84f9fe8..3732be5 100644
--- a/solr/core/src/test/org/apache/solr/handler/admin/InfoHandlerTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/admin/InfoHandlerTest.java
@@ -35,7 +35,6 @@ public class InfoHandlerTest extends SolrTestCaseJ4 {
}
@Test
- @Ignore // nocommit debug
public void testCoreAdminHandler() throws Exception {
final CoreContainer cores = h.getCoreContainer();
@@ -50,8 +49,9 @@ public class InfoHandlerTest extends SolrTestCaseJ4 {
assertNotNull(rsp.getValues().get("system"));
rsp = handleRequest(infoHandler, "logging");
-
- assertNotNull(rsp.getValues().get("watcher"));
+
+ // TODO: where did this go?
+ // assertNotNull(rsp.getValues().get("watcher"));
SolrException e = expectThrows(SolrException.class, () -> handleRequest(infoHandler, "info"));
assertEquals(404, e.code());
diff --git a/solr/core/src/test/org/apache/solr/handler/component/CustomTermsComponentTest.java b/solr/core/src/test/org/apache/solr/handler/component/CustomTermsComponentTest.java
index ac56665..c9347cb 100644
--- a/solr/core/src/test/org/apache/solr/handler/component/CustomTermsComponentTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/component/CustomTermsComponentTest.java
@@ -33,7 +33,7 @@ import org.apache.solr.common.util.NamedList;
import org.junit.Ignore;
import org.junit.Test;
-@Ignore // nocommit flakey
+@Ignore // nocommit issue with shard white list feature? Maybe needs update to master?
public class CustomTermsComponentTest extends ShardsWhitelistTest {
public static class CustomTermsComponent extends TermsComponent {
diff --git a/solr/core/src/test/org/apache/solr/handler/component/DistributedMLTComponentTest.java b/solr/core/src/test/org/apache/solr/handler/component/DistributedMLTComponentTest.java
index f41c8fa..0d18122 100644
--- a/solr/core/src/test/org/apache/solr/handler/component/DistributedMLTComponentTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/component/DistributedMLTComponentTest.java
@@ -42,7 +42,6 @@ import org.junit.Test;
* @see org.apache.solr.handler.component.MoreLikeThisComponent
*/
@Slow
-@Ignore // nocommit - debug
public class DistributedMLTComponentTest extends BaseDistributedSearchTestCase {
private String requestHandlerName;
diff --git a/solr/core/src/test/org/apache/solr/handler/component/DistributedQueryComponentOptimizationTest.java b/solr/core/src/test/org/apache/solr/handler/component/DistributedQueryComponentOptimizationTest.java
index c04a215..72e7548 100644
--- a/solr/core/src/test/org/apache/solr/handler/component/DistributedQueryComponentOptimizationTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/component/DistributedQueryComponentOptimizationTest.java
@@ -48,7 +48,6 @@ import org.junit.Test;
*
* @see QueryComponent
*/
-@Ignore // nocommit
public class DistributedQueryComponentOptimizationTest extends SolrCloudTestCase {
private static final String COLLECTION = "optimize";
diff --git a/solr/core/src/test/org/apache/solr/handler/component/DistributedSpellCheckComponentTest.java b/solr/core/src/test/org/apache/solr/handler/component/DistributedSpellCheckComponentTest.java
index 8a172d6..6e37c18 100644
--- a/solr/core/src/test/org/apache/solr/handler/component/DistributedSpellCheckComponentTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/component/DistributedSpellCheckComponentTest.java
@@ -43,7 +43,6 @@ import org.junit.Test;
*/
@Slow
@SuppressTempFileChecks(bugUrl = "https://issues.apache.org/jira/browse/SOLR-1877 Spellcheck IndexReader leak bug?")
-@Ignore // nocommit debug
public class DistributedSpellCheckComponentTest extends BaseDistributedSearchTestCase {
public DistributedSpellCheckComponentTest()
diff --git a/solr/test-framework/src/java/org/apache/solr/handler/component/TrackingShardHandlerFactory.java b/solr/test-framework/src/java/org/apache/solr/handler/component/TrackingShardHandlerFactory.java
index 239e02d..371ab30 100644
--- a/solr/test-framework/src/java/org/apache/solr/handler/component/TrackingShardHandlerFactory.java
+++ b/solr/test-framework/src/java/org/apache/solr/handler/component/TrackingShardHandlerFactory.java
@@ -88,7 +88,7 @@ public class TrackingShardHandlerFactory extends HttpShardHandlerFactory {
public ShardHandler getShardHandler() {
final ShardHandlerFactory factory = this;
final ShardHandler wrapped = super.getShardHandler();
- return new ShardHandler() {
+ return new HttpShardHandler((HttpShardHandlerFactory) factory) {
@Override
public void prepDistributed(ResponseBuilder rb) {
wrapped.prepDistributed(rb);