You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/08/07 16:04:26 UTC
[GitHub] [openwhisk-runtime-java] dgrove-oss commented on a diff in pull request #140: Support array result include sequence action
dgrove-oss commented on code in PR #140:
URL: https://github.com/apache/openwhisk-runtime-java/pull/140#discussion_r939689436
##########
core/java8actionloop/Dockerfile:
##########
@@ -31,13 +31,13 @@ RUN curl -sL \
https://github.com/apache/openwhisk-runtime-go/archive/{$GO_PROXY_RELEASE_VERSION}.tar.gz\
| tar xzf -\
&& cd openwhisk-runtime-go-*/main\
- && GO111MODULE=on go build -o /bin/proxy
+ && GO111MODULE=on CGO_ENABLED=0 go build -o /bin/proxy
# Use AdoptOpenJDK's JDK8, OpenJ9, ubuntu
FROM ibm-semeru-runtimes:open-8u332-b09-jdk-focal
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=release
+ARG GO_PROXY_BUILD_FROM=source
Review Comment:
We could do a wave of runtime releases, starting the the go runtime. Would be reasonable to plan to get the go runtime released this week (takes 72 hours for the vote).
##########
core/java8actionloop/Dockerfile:
##########
@@ -31,13 +31,13 @@ RUN curl -sL \
https://github.com/apache/openwhisk-runtime-go/archive/{$GO_PROXY_RELEASE_VERSION}.tar.gz\
| tar xzf -\
&& cd openwhisk-runtime-go-*/main\
- && GO111MODULE=on go build -o /bin/proxy
+ && GO111MODULE=on CGO_ENABLED=0 go build -o /bin/proxy
# Use AdoptOpenJDK's JDK8, OpenJ9, ubuntu
FROM ibm-semeru-runtimes:open-8u332-b09-jdk-focal
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=release
+ARG GO_PROXY_BUILD_FROM=source
Review Comment:
We could do a wave of runtime releases, starting with the go runtime. Would be reasonable to plan to get the go runtime released this week (takes 72 hours for the vote).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org