You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/14 09:07:20 UTC
[jira] [Commented] (STORM-1969) Modify HiveTopology to show usage
of non-partition table
[ https://issues.apache.org/jira/browse/STORM-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376620#comment-15376620 ]
ASF GitHub Bot commented on STORM-1969:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1564
STORM-1969 Modify HiveTopology to show usage of non-partition table
There're some kinds of topology in storm-hive, but all of them uses partition so we don't have example for accessing non-partition table. It would be better to have one for automated tests.
Instead of creating a new topology, we can modify HiveTopology to not use partition at all. BucketTestHiveTopology and TridentHiveTopology also use DelimitedRecordHiveMapper.withTimeAsPartitionField() so I think usage of withTimeAsPartitionField() is covered.
It can be ported back easily so I don't create pull requests for other branches.
We would be better to have this to 1.x and maybe 1.0.x, too.
Please review and comment. Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1969
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1564.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1564
----
commit 322b93d8c6ba9cb064beae520c3c16a263d8631f
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-14T09:02:06Z
STORM-1969 Modify HiveTopology to show usage of non-partition table
* HiveTopology is no longer using partition
----
> Modify HiveTopology to show usage of non-partition table
> --------------------------------------------------------
>
> Key: STORM-1969
> URL: https://issues.apache.org/jira/browse/STORM-1969
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-hive
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Minor
>
> There're some kinds of topology in storm-hive, but all of them uses partition so we don't have example for accessing non-partition table. It would be better to have one for automated tests.
> Instead of creating a new topology, we can modify HiveTopology to not use partition at all. BucketTestHiveTopology and TridentHiveTopology also use DelimitedRecordHiveMapper.withTimeAsPartitionField() so I think usage of withTimeAsPartitionField() is covered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)