[GitHub] [airflow] uranusjr commented on a diff in pull request #27008: Exit on exitcode 1 in breeze

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #27008:
URL: https://github.com/apache/airflow/pull/27008#discussion_r993222760


##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -589,6 +589,9 @@ def run_shell(verbose: bool, dry_run: bool, shell_params: ShellParams) -> RunCom
     )
     if command_result.returncode == 0:
         return command_result
+    elif command_result.returncode == 1:
+        get_console().print(f"[red]Error {command_result.returncode} returned[/]")
+        sys.exit(1)

Review Comment:
   I think this should be a part of the `else` block below; this is bubbled up to `enter_shell` and we should call `sys.exit` there instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org