You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/29 19:28:48 UTC

[GitHub] [flink] bowenli86 opened a new pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service

bowenli86 opened a new pull request #8567: [FLINK-12676][table][sql-client] Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service
URL: https://github.com/apache/flink/pull/8567
 
 
   ## What is the purpose of the change
   
   This PR adds descriptor, validator, and factory of GenericInMemoryCatalog, and enables SQL CLI to load a generic in memory catalog thru yaml config and table discovery service.
   
   It contains 3 parts:
   
   - commit a754fce8cc91787cf9225a3be166962c4ebafde6 Support 'default-database' config for catalog entries in SQL CLI yaml file
   - commit 45742158839b86dda2e0c93a172d9c50b4aae6e2 Add AbstractCatalog to manage the common catalog name and default database name for catalogs
   - commit 4c37d371467b54514f91785497af1e3a8b7102c7 Add descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service
   
   ## Brief change log
   
   - Added an optional 'default-database' config for catalog entries in SQL CLI yaml file
   - Added AbstractCatalog to manage the common catalog name and default database name for catalogs to manage common parts of catalog impls and facilitate comparing catalogs in catalog factory tests
   - Developed descriptor, validator, and factory of GenericInMemoryCatalog for table discovery service
   - Wrote unit tests for descriptor, validator, and factory of GenericInMemoryCatalog
   
   Descriptor, validator, factory, and unit tests are built by referencing existing classes.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - DependencyTest
   - ExecutionContextTest.java
   - GenericInMemoryCatalogFactoryTest.java 
   - GenericInMemoryCatalogDescriptorTest.java
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs)
   
   Documents will be added later

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services