You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/08/22 15:25:35 UTC

[GitHub] [httpcomponents-client] bekker commented on a change in pull request #162: Modify RequestConfig Javadoc

bekker commented on a change in pull request #162: Modify RequestConfig Javadoc
URL: https://github.com/apache/httpcomponents-client/pull/162#discussion_r316742070
 
 

 ##########
 File path: httpclient/src/main/java/org/apache/http/client/config/RequestConfig.java
 ##########
 @@ -295,11 +293,11 @@ public int getConnectTimeout() {
 
     /**
      * Defines the socket timeout ({@code SO_TIMEOUT}) in milliseconds,
-     * which is the timeout for waiting for data  or, put differently,
+     * which is the timeout for waiting for data or, put differently,
      * a maximum period inactivity between two consecutive data packets).
      * <p>
      * A timeout value of zero is interpreted as an infinite timeout.
-     * A negative value is interpreted as undefined (system default).
+     * A negative value is interpreted as undefined.
 
 Review comment:
   I was not so sure about other timeouts. Would it be better to make it same for other timeouts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org