You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/05 18:40:01 UTC

[GitHub] [flink] zentol commented on a change in pull request #13042: [FLINK-16510] Allow configuring shutdown behavior to avoid JVM freeze

zentol commented on a change in pull request #13042:
URL: https://github.com/apache/flink/pull/13042#discussion_r465927278



##########
File path: flink-core/src/main/java/org/apache/flink/configuration/ClusterOptions.java
##########
@@ -78,4 +79,13 @@
 				.text("Enable the slot spread out allocation strategy. This strategy tries to spread out " +
 					"the slots evenly across all available %s.", code("TaskExecutors"))
 				.build());
+
+	@Documentation.Section(Documentation.Sections.EXPERT_CLUSTER)
+	public static final ConfigOption<Boolean> HALT_ON_FATAL_ERROR =
+		key("cluster.processes.halt-on-fatal-error")

Review comment:
       You will need to regenerate the documentation.

##########
File path: flink-annotations/src/main/java/org/apache/flink/annotation/docs/Documentation.java
##########
@@ -91,6 +91,7 @@
 		public static final String EXPERT_ZOOKEEPER_HIGH_AVAILABILITY = "expert_high_availability_zk";
 		public static final String EXPERT_SECURITY_SSL = "expert_security_ssl";
 		public static final String EXPERT_ROCKSDB = "expert_rocksdb";
+		public static final String EXPERT_CLUSTER = "expert_cluster";

Review comment:
       You need to include this section into the `config.md` for it to show up.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org