[GitHub] piotrzarzycki21 commented on a change in pull request #292: new component snackbar

[GitBox <gi...@apache.org>]

piotrzarzycki21 commented on a change in pull request #292: new component snackbar
URL: https://github.com/apache/royale-asjs/pull/292#discussion_r216153414
 
 

 ##########
 File path: frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/models/SnackbarModel.as
 ##########
 @@ -0,0 +1,143 @@
+////////////////////////////////////////////////////////////////////////////////
+//
+//  Licensed to the Apache Software Foundation (ASF) under one or more
+//  contributor license agreements.  See the NOTICE file distributed with
+//  this work for additional information regarding copyright ownership.
+//  The ASF licenses this file to You under the Apache License, Version 2.0
+//  (the "License"); you may not use this file except in compliance with
+//  the License.  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+package org.apache.royale.jewel.beads.models
+{	
+	import org.apache.royale.core.IBead;
+	import org.apache.royale.core.IBeadModel;
+	import org.apache.royale.core.IStrand;
+	import org.apache.royale.events.Event;
+	import org.apache.royale.events.EventDispatcher;
+		
+	/**
+	 *  The SnackbarModel class bead defines the data associated with an org.apache.royale.jewel.Snackbar
+	 *  component. This includes a message, the action and duration - how long to show the view for.
+	 *  
+	 *  @langversion 3.0
+	 *  @playerversion Flash 10.2
+	 *  @playerversion AIR 2.6
+	 *  @productversion Royale 0.9.4
+	 */
+	public class SnackbarModel extends EventDispatcher implements IBead, IBeadModel
+	{
+        /**
+         *  Constructor.
+         *  
+	     *  @langversion 3.0
+	     *  @playerversion Flash 10.2
+	     *  @playerversion AIR 2.6
+	     *  @productversion Royale 0.9.4
+         */
+		public function SnackbarModel()
+		{
+            super();
+		}
+
+		private var _strand:IStrand;
+		
+        /**
+         *  @copy org.apache.royale.core.IBead#strand
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion Royale 0.9.4
+         */
+		public function set strand(value:IStrand):void
+		{
+			_strand = value;
+		}
+
+		private var _message:String;
+
+        [Bindable("messageChange")]
+        public function get message():String
+		{
+			return _message;
+		}
+		
+        /**
+         *  Set message to be displayed.
+         *  
+         *  @langversion 3.0
+         *  @playerversion Flash 10.2
+         *  @playerversion AIR 2.6
+         *  @productversion Royale 0.9.4
+         */
+		public function set message(value:String):void
+		{
+            if (value == null)
+                value = "";
 
 Review comment:
   Why message cannot be null, because it's displays on UI? What if it will be undefined?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services