[GitHub] SongYadong commented on a change in pull request #23869: [SPARK-26967][CORE] Put MetricsSystem instance names together for clearer management

[GitBox <gi...@apache.org>]

SongYadong commented on a change in pull request #23869: [SPARK-26967][CORE] Put MetricsSystem instance names together for clearer management
URL: https://github.com/apache/spark/pull/23869#discussion_r259558347
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
 ##########
 @@ -235,3 +235,32 @@ private[spark] object MetricsSystem {
     new MetricsSystem(instance, conf, securityMgr)
   }
 }
+
+private[spark] object MetricsSystemInstances {
+  // The Spark standalone master process
+  val MASTER = "master"
 
 Review comment:
   Thanks. The locations you pointed out are metrics `Source `names, which should not reference `MetricsSystem `instance names. Of course your comment is enlightening. Maybe we could also put metrics `Source `names together ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org