You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/04 13:04:37 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #31700: [SPARK-34183][SS] DataSource V2: Support required distribution and ordering in SS

cloud-fan commented on a change in pull request #31700:
URL: https://github.com/apache/spark/pull/31700#discussion_r587452749



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -166,6 +166,52 @@ object OverwritePartitionsDynamic {
   }
 }
 
+case class AppendMicroBatch(

Review comment:
       I don't think we have finalized the streaming writing semantic yet. Ideally, it should be similar to batch (upsert semantic), but we are not at that point yet.
   
   I think we should standardize the streaming writing query plan later. For now, let's just use one query plan with `OutputMode` as the parameter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org