[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1756: SOLR-14750: Invoke core reload with core id to avoid multiple reloads

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1756:
URL: https://github.com/apache/lucene-solr/pull/1756#discussion_r471774466



##########
File path: solr/core/src/java/org/apache/solr/schema/SchemaManager.java
##########
@@ -21,10 +21,7 @@
 import java.io.StringWriter;
 import java.lang.invoke.MethodHandles;
 import java.nio.charset.StandardCharsets;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;

Review comment:
       This is highly configurable; we are in control of it.  Our project already has an IntelliJ code style setting that sets the threshold to 20:  https://github.com/apache/lucene-solr/blob/99e54ab044283cc8316667957299b890265e0580/dev-tools/idea/.idea/codeStyleSettings.xml#L21
   I use this and I recommend we all do the same.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org