You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2019/12/25 10:28:47 UTC
[commons-io] branch master updated: Performance Enhancement: Call
toArray with Zero Array Size (closes #65)
This is an automated email from the ASF dual-hosted git repository.
pascalschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
The following commit(s) were added to refs/heads/master by this push:
new bcb3604 Performance Enhancement: Call toArray with Zero Array Size (closes #65)
bcb3604 is described below
commit bcb3604177b7b86d740536138bde8d19e4668cf0
Author: David Georg Reichelt <da...@dagere.de>
AuthorDate: Wed Oct 10 12:09:03 2018 +0200
Performance Enhancement: Call toArray with Zero Array Size (closes #65)
toArray should, at least since Java 7, be used with new T[0] instead of size, since it is "faster, safer, and contractually cleaner" (https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_conclusion)
---
src/main/java/org/apache/commons/io/FilenameUtils.java | 4 ++--
.../org/apache/commons/io/comparator/CompositeFileComparator.java | 2 +-
src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java | 4 ++--
src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java | 2 +-
src/main/java/org/apache/commons/io/filefilter/PrefixFileFilter.java | 2 +-
src/main/java/org/apache/commons/io/filefilter/SuffixFileFilter.java | 2 +-
.../java/org/apache/commons/io/filefilter/WildcardFileFilter.java | 2 +-
src/main/java/org/apache/commons/io/filefilter/WildcardFilter.java | 2 +-
8 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/main/java/org/apache/commons/io/FilenameUtils.java b/src/main/java/org/apache/commons/io/FilenameUtils.java
index cf7c7cf..e77a2db 100644
--- a/src/main/java/org/apache/commons/io/FilenameUtils.java
+++ b/src/main/java/org/apache/commons/io/FilenameUtils.java
@@ -1494,7 +1494,7 @@ public class FilenameUtils {
list.add(buffer.toString());
}
- return list.toArray( new String[ list.size() ] );
+ return list.toArray( new String[ 0 ] );
}
/**
@@ -1577,7 +1577,7 @@ public class FilenameUtils {
} else if (inet6Address.startsWith("::") && !octetList.isEmpty()) {
octetList.remove(0);
}
- octets = octetList.toArray(new String[octetList.size()]);
+ octets = octetList.toArray(new String[0]);
}
if (octets.length > IPV6_MAX_HEX_GROUPS) {
return false;
diff --git a/src/main/java/org/apache/commons/io/comparator/CompositeFileComparator.java b/src/main/java/org/apache/commons/io/comparator/CompositeFileComparator.java
index 7bfaa26..18d3850 100644
--- a/src/main/java/org/apache/commons/io/comparator/CompositeFileComparator.java
+++ b/src/main/java/org/apache/commons/io/comparator/CompositeFileComparator.java
@@ -76,7 +76,7 @@ public class CompositeFileComparator extends AbstractFileComparator implements S
for (final Comparator<File> comparator : delegates) {
list.add(comparator);
}
- this.delegates = (Comparator<File>[]) list.toArray(new Comparator<?>[list.size()]); //2
+ this.delegates = (Comparator<File>[]) list.toArray(new Comparator<?>[0]); //2
}
}
diff --git a/src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java b/src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java
index 60ffc0e..c654ecd 100644
--- a/src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java
+++ b/src/main/java/org/apache/commons/io/filefilter/FileFilterUtils.java
@@ -89,7 +89,7 @@ public class FileFilterUtils {
acceptedFiles.add(file);
}
}
- return acceptedFiles.toArray(new File[acceptedFiles.size()]);
+ return acceptedFiles.toArray(new File[0]);
}
/**
@@ -120,7 +120,7 @@ public class FileFilterUtils {
*/
public static File[] filter(final IOFileFilter filter, final Iterable<File> files) {
final List<File> acceptedFiles = filterList(filter, files);
- return acceptedFiles.toArray(new File[acceptedFiles.size()]);
+ return acceptedFiles.toArray(new File[0]);
}
/**
diff --git a/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java
index 8d8bad0..8f5de20 100644
--- a/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/NameFileFilter.java
@@ -126,7 +126,7 @@ public class NameFileFilter extends AbstractFileFilter implements Serializable {
if (names == null) {
throw new IllegalArgumentException("The list of names must not be null");
}
- this.names = names.toArray(new String[names.size()]);
+ this.names = names.toArray(new String[0]);
this.caseSensitivity = caseSensitivity == null ? IOCase.SENSITIVE : caseSensitivity;
}
diff --git a/src/main/java/org/apache/commons/io/filefilter/PrefixFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/PrefixFileFilter.java
index 11962d6..c1327a2 100644
--- a/src/main/java/org/apache/commons/io/filefilter/PrefixFileFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/PrefixFileFilter.java
@@ -134,7 +134,7 @@ public class PrefixFileFilter extends AbstractFileFilter implements Serializable
if (prefixes == null) {
throw new IllegalArgumentException("The list of prefixes must not be null");
}
- this.prefixes = prefixes.toArray(new String[prefixes.size()]);
+ this.prefixes = prefixes.toArray(new String[0]);
this.caseSensitivity = caseSensitivity == null ? IOCase.SENSITIVE : caseSensitivity;
}
diff --git a/src/main/java/org/apache/commons/io/filefilter/SuffixFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/SuffixFileFilter.java
index d4d0db3..0f548b6 100644
--- a/src/main/java/org/apache/commons/io/filefilter/SuffixFileFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/SuffixFileFilter.java
@@ -135,7 +135,7 @@ public class SuffixFileFilter extends AbstractFileFilter implements Serializable
if (suffixes == null) {
throw new IllegalArgumentException("The list of suffixes must not be null");
}
- this.suffixes = suffixes.toArray(new String[suffixes.size()]);
+ this.suffixes = suffixes.toArray(new String[0]);
this.caseSensitivity = caseSensitivity == null ? IOCase.SENSITIVE : caseSensitivity;
}
diff --git a/src/main/java/org/apache/commons/io/filefilter/WildcardFileFilter.java b/src/main/java/org/apache/commons/io/filefilter/WildcardFileFilter.java
index 7eef9a4..b8486a3 100644
--- a/src/main/java/org/apache/commons/io/filefilter/WildcardFileFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/WildcardFileFilter.java
@@ -134,7 +134,7 @@ public class WildcardFileFilter extends AbstractFileFilter implements Serializab
if (wildcards == null) {
throw new IllegalArgumentException("The wildcard list must not be null");
}
- this.wildcards = wildcards.toArray(new String[wildcards.size()]);
+ this.wildcards = wildcards.toArray(new String[0]);
this.caseSensitivity = caseSensitivity == null ? IOCase.SENSITIVE : caseSensitivity;
}
diff --git a/src/main/java/org/apache/commons/io/filefilter/WildcardFilter.java b/src/main/java/org/apache/commons/io/filefilter/WildcardFilter.java
index 40ef96d..1603652 100644
--- a/src/main/java/org/apache/commons/io/filefilter/WildcardFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/WildcardFilter.java
@@ -93,7 +93,7 @@ public class WildcardFilter extends AbstractFileFilter implements Serializable {
if (wildcards == null) {
throw new IllegalArgumentException("The wildcard list must not be null");
}
- this.wildcards = wildcards.toArray(new String[wildcards.size()]);
+ this.wildcards = wildcards.toArray(new String[0]);
}
//-----------------------------------------------------------------------