You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/09 02:07:04 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #5407: [INLONG-5401][Manager] Fix StreamSinkFieldEntity and SinkField fields not match

healchow commented on code in PR #5407:
URL: https://github.com/apache/inlong/pull/5407#discussion_r940817095


##########
inlong-manager/manager-dao/src/main/resources/mappers/StreamSinkFieldEntityMapper.xml:
##########
@@ -37,10 +37,13 @@
         <result column="field_format" jdbcType="VARCHAR" property="fieldFormat"/>
         <result column="rank_num" jdbcType="SMALLINT" property="rankNum"/>
         <result column="is_deleted" jdbcType="INTEGER" property="isDeleted"/>
+        <result column="origin_node_name" jdbcType="VARCHAR" property="originNodeName"/>

Review Comment:
   Suggests moving those two fields after the `field_format` field, because the `is_deleted` field was a unified field of each table, it should be at the end of each table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org