You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/16 09:54:55 UTC

[GitHub] [dolphinscheduler-sdk-python] jieguangzhou opened a new pull request, #50: [Feat] Add task caching mechanism to improve the running speed of repetitive tasks

jieguangzhou opened a new pull request, #50:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/50

   <!--Thanks for you contribute to Apache DolphinScheduler Python API, You can see more detail about contributing in https://github.com/apache/dolphinscheduler-sdk-python/DEVELOP.md .-->
   
   ## Brief Summary of The Change
   close: #49
   
   ## Pull Request checklist
   
   I confirm that the following checklist has been completed.
   
   - [ ] Add/Change **test cases** for the changes.
   - [ ] Add/Change the related **documentation**, should also change `docs/source/config.rst` when you change file `default_config.yaml`.
   - [ ] (Optional) Add your change to `UPDATING.md` when it is an incompatible change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler-sdk-python] zhongjiajie commented on pull request #50: [Feat] Add task caching mechanism to improve the running speed of repetitive tasks

Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on PR #50:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/50#issuecomment-1481058822

   > Do not merge until [apache/dolphinscheduler#13194](https://github.com/apache/dolphinscheduler/pull/13194) is merged
   
   may releasing in version apache/dolphinscheduler:3.2.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler-sdk-python] codecov-commenter commented on pull request #50: [Feat] Add task caching mechanism to improve the running speed of repetitive tasks

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #50:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/50#issuecomment-1354492001

   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/50?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#50](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/50?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ff8e0b) into [main](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/commit/f82e07d232380fe9f5582db4dcca920ae00befd4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f82e07d) will **increase** coverage by `0.07%`.
   > The diff coverage is `88.88%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main      #50      +/-   ##
   ==========================================
   + Coverage   90.71%   90.79%   +0.07%     
   ==========================================
     Files          59       60       +1     
     Lines        2090     2119      +29     
   ==========================================
   + Hits         1896     1924      +28     
   - Misses        194      195       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `90.79% <88.88%> (+0.07%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/50?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [src/pydolphinscheduler/core/task.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/50/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL3Rhc2sucHk=) | `93.25% <83.33%> (-0.35%)` | :arrow_down: |
   | [src/pydolphinscheduler/constants.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/50/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb25zdGFudHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [src/pydolphinscheduler/utils/versions.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/50/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci91dGlscy92ZXJzaW9ucy5weQ==) | `100.00% <0.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler-sdk-python] jieguangzhou merged pull request #50: [Feat] Add task caching mechanism to improve the running speed of repetitive tasks

Posted by GitBox <gi...@apache.org>.
jieguangzhou merged PR #50:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/50


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler-sdk-python] jieguangzhou commented on pull request #50: [Feat] Add task caching mechanism to improve the running speed of repetitive tasks

Posted by GitBox <gi...@apache.org>.
jieguangzhou commented on PR #50:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/50#issuecomment-1354485566

   Do not merge until https://github.com/apache/dolphinscheduler/pull/13194 is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler-sdk-python] zhongjiajie commented on pull request #50: [Feat] Add task caching mechanism to improve the running speed of repetitive tasks

Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on PR #50:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/50#issuecomment-1481047997

   dependence on dolphinscheduler 3.2.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org