You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/19 18:47:57 UTC
[GitHub] [incubator-nuttx] mogenson opened a new pull request #5805: nxstyle: ignore mixed-case identifiers for Lua types
mogenson opened a new pull request #5805:
URL: https://github.com/apache/incubator-nuttx/pull/5805
## Summary
Silence `nxstyle` mixed-case identifier warnings for Lua types. Notably, Lua C modules that use the `lua_State` and `luaL_Reg` types.
Related to https://github.com/apache/incubator-nuttx-apps/pull/1075
## Impact
Should not affect non-Lua C module style lints. The prefixes `lua_` and `luaL_` do not exist anywhere else in the NuttX codebase.
## Testing
Ran `nxstyle` on `luamod_hello.c` from `apps/examples/lua_module/`. No mixed-case identifier warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5805: nxstyle: ignore mixed-case identifiers for Lua types
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5805:
URL: https://github.com/apache/incubator-nuttx/pull/5805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5805: nxstyle: ignore mixed-case identifiers for Lua types
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5805:
URL: https://github.com/apache/incubator-nuttx/pull/5805#issuecomment-1073159420
@mogenson please rebase your patch to the last mainline, CI break was fixed by: https://github.com/apache/incubator-nuttx/pull/5804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5805: nxstyle: ignore mixed-case identifiers for Lua types
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5805:
URL: https://github.com/apache/incubator-nuttx/pull/5805#issuecomment-1073275705
Since it's simple change, let's ignore CI break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org