You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/28 03:11:58 UTC
[jira] [Commented] (S2GRAPH-131) Add actual implementation on
interfaces from TinkerPop3 structure package.
[ https://issues.apache.org/jira/browse/S2GRAPH-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15700776#comment-15700776 ]
ASF GitHub Bot commented on S2GRAPH-131:
----------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/101
[S2GRAPH-131]: Add actual implementation on interfaces from TinkerPop3 structure package.
- Change core.Edge/Vertex/Graph to core.S2Edge/S2Vertex/S2Graph.
- Implement base interfaces for tinkerpop3 structure package.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-131
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #101
----
commit 292174ecf8da32604d61cb5f8388b8d9eeb54be3
Author: DO YUNG YOON <st...@apache.org>
Date: 2016-11-24T01:46:27Z
[S2GRAPH-129]: Restrict direct access on Edge's properties from other classes.
- add tp3 as dependencies.
- make propsWithTs as private.
commit 6356573e6a658dbfeb240bdee642d055991e5ac2
Author: DO YUNG YOON <st...@apache.org>
Date: 2016-11-24T03:14:08Z
[S2GRAPH-130]: Edge.propsWithTs data type should be changed into mutable to support setter interface exist in tp3.
- Make Vertex/Edge/Graph to implement Tinkerpop3.
- Change data type of Edge's propsWithTs to java.util.Map[String, S2Property[_]].
commit a81a74c83fa5e51c56625fc3dd24a2da4fe56457
Author: DO YUNG YOON <st...@apache.org>
Date: 2016-11-24T05:13:54Z
run apache-rat to add apache license headers on new files.
commit 189bc41e04818833792899b37e15ffe88f9f98ad
Author: DO YUNG YOON <st...@apache.org>
Date: 2016-11-25T00:59:54Z
- add graph on Vertex.
- change colId into ServiceColumn in VertexId.
commit e8c0bf20b517a2e9a752df63c156fc265b7365b6
Author: DO YUNG YOON <st...@apache.org>
Date: 2016-11-28T03:09:52Z
[S2GRAPH-131]: Add actual implementation on interfaces from TinkerPop3 structure package.
- Change core.Edge/Vertex/Graph to core.S2Edge/S2Vertex/S2Graph.
- Implement base interfaces for tinkerpop3 structure package.
----
> Add actual implementation on interfaces from TinkerPop3 structure package.
> --------------------------------------------------------------------------
>
> Key: S2GRAPH-131
> URL: https://issues.apache.org/jira/browse/S2GRAPH-131
> Project: S2Graph
> Issue Type: Sub-task
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Fix For: 0.2.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Based on changes from S2GRAPH-129, S2GRAPH-130, it's easy to implement tinkerpop3's structure interfaces directly.
> This issue is about change our previous core entity {{Edge/Vertex/Graph}} into {{S2Edge/S2Vertex/S2Graph}}.
> I suggest to focus on naive implementation first on this issue, then improve tp3 integration while we discuss.
> Of course test cases, documentations should be followed up.
> I suggest to create more subtask under S2GRAPH-72, so we can track them easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)